Skip to content

chore: return error as last argument #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huiyifyj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: return error as last argument #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gravatar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type Gravatar struct {
func (v *Verifier) CheckGravatar(email string) (*Gravatar, error) {
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
err, emailMd5 := getMD5Hash(strings.ToLower(strings.TrimSpace(email)))
emailMd5, err := getMD5Hash(strings.ToLower(strings.TrimSpace(email)))
if err != nil {
return nil, err
}
Expand All @@ -41,7 +41,7 @@ func (v *Verifier) CheckGravatar(email string) (*Gravatar, error) {
return nil, err
}
// check body
err, md5Body := getMD5Hash(string(body))
md5Body, err := getMD5Hash(string(body))
if err != nil {
return nil, err
}
Expand Down
6 changes: 3 additions & 3 deletions util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ func callJobFuncWithParams(jobFunc interface{}, params []interface{}) []reflect.

// getMD5Hash use md5 to encode string
// #nosec
func getMD5Hash(str string) (error, string) {
func getMD5Hash(str string) (string, error) {
h := md5.New()
_, err := h.Write([]byte(str))
if err != nil {
return err, ""
return "", err
}
return nil, hex.EncodeToString(h.Sum(nil))
return hex.EncodeToString(h.Sum(nil)), nil
}