Conversation
logout -> signOut 명칭 수정
커버리지 75%
1971123-seongmin
approved these changes
Jul 1, 2025
| _userType.emit(UserType.GUEST) | ||
| else | ||
| _userType.emit(UserType.USER) | ||
| private val userType = _userType.asStateFlow() |
Member
There was a problem hiding this comment.
기존 방식에서 _userType.asStateFlow와 scope.launch 방식으로 바꾸신 이유를 설명해주실 수 있나요??
Collaborator
Author
There was a problem hiding this comment.
동작에는 문제없었는데, 코드가 좀 모호해보여서 좀 더 명확해보이게 바꿧습니다
| reissueTokenApi: ReissueTokenApi, | ||
| appLauncher: AppLauncher | ||
| ): Authenticator = AuthAuthenticator(context, tokenLocalDataSource, userRepository, reissueTokenApi, appLauncher) | ||
| ): Authenticator = AuthAuthenticator(context, tokenLocalDataSource, sessionHandler, reissueTokenApi, appLauncher) |
Member
There was a problem hiding this comment.
기존에 여기에서 순환참조 문제가 발생했었나요?? 간단히 설명해주실 수 있나요??
Collaborator
Author
There was a problem hiding this comment.
기존에 Authenticator에서 SessionManager를 사용하던걸 그냥 UserRepository를 사용하는걸로 리팩토링했는데,
여기서 순환참조 발생하더라구여
UserRepository -> UserRemoteDataSource -> UserApi -> Retrofit -> OkHttpClient -> Authenticator -> UserRepository -> ...
그래서 다시 SessionHandler라는 이름으로 부활시켰습니다,,,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧨 Issue
💻 Work Description
💭 To Reviewers