[Refactor/#99] 모듈 구조 재정립 - #210
Merged
Merged
Conversation
FeatureConventionPlugin로 Feature 모듈의 모듈 의존성 관리
빌드 에러 전체 수정, compose-stable-marker 제거
ThirFir
force-pushed
the
refactor/#99-modules
branch
from
June 28, 2025 13:58
b20c985 to
88a41c7
Compare
1971123-seongmin
approved these changes
Jun 29, 2025
| LaunchedEffect(userType) { | ||
| _userType.value = userType | ||
| LaunchedEffect(Unit) { | ||
| snapshotFlow { userType }.collect { |
Member
There was a problem hiding this comment.
여기를 snapshotFlow로 바꾸신 이유가 뭔지 설명해주실 수 있나요?
Collaborator
Author
There was a problem hiding this comment.
자주 바뀔 수 있는 값인데, LaunchedEffect 키로 걸어주면 바뀔 때마다 코루틴이 재실행되므로 비효율적이라고 판단했기 때문입니다
| liveLocation.emit(newLocation) | ||
| newLocation?.let { onNewLocation(it) } | ||
| LaunchedEffect(Unit) { | ||
| snapshotFlow { newLocation }.filterNotNull().collect { |
Member
There was a problem hiding this comment.
여기도 snapshotFlow로 바꾸신 이유가 뭔지 설명해주실 수 있나요?
| include(":feature:ads-impl") | ||
| include(":core:ui") | ||
| include(":core:model") | ||
| include(":core:navigation") |
Member
There was a problem hiding this comment.
core-navigation 모듈만 따로 만드신 이유가 뭔지 설명해주실 수 있나요?
Collaborator
Author
There was a problem hiding this comment.
분리할 수 있는 건 최대한 분리하고자 모듈화했습니다
Navigation 관련 유틸이나, Route들은 여기서 관리될 수 있습니다
| android:name="android.permission.READ_EXTERNAL_STORAGE" | ||
| android:maxSdkVersion="32" /> | ||
|
|
||
| <uses-permission android:name="android.permission.READ_PHONE_STATE" /> |
Collaborator
Author
There was a problem hiding this comment.
제가 선언한건 아니고 다른 곳에서 사용되고 있던걸 모듈 정리하면서 옮겼습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧨 Issue
💻 Work Description
💭 To Reviewers
( -> : 의존, NEW: 새로 생성한 모듈)
대충 이런 의존 관계로 정립했는데, 그래프로 표현하려고 해봤는데 잘 안되네요 ㅠ 다시 시도해봐야겠음....
코드 변경은 거의 없습니다. 모듈 이동만 있을 뿐
다음 작업은 build-logic 나누는 기준 좀 다시 잡아봐야겠습니다