Skip to content

Fix metrics port conditions in Services - #43

Open
callumweb3 wants to merge 2 commits into
Abstract-Foundation:mainfrom
callumweb3:service
Open

callumweb3 wants to merge 2 commits into
Abstract-Foundation:mainfrom
callumweb3:service

Conversation

@callumweb3

@callumweb3 callumweb3 commented Sep 15, 2026

Copy link
Copy Markdown

service.yaml and service-core.yaml only exposed the metrics port when global.metrics.enabled was enabled, while the workloads expose the metrics port when either global.metrics.enabled or metrics.enabled is true.

Update both Services to use the same condition as the workloads, so metrics.enabled: true correctly exposes the metrics port through the Service.

The condition is already used in:


PR-Codex overview

This PR focuses on updating the conditional logic for enabling metrics in the service.yaml and service-core.yaml templates. It modifies the conditions to include both global and local metrics settings.

Detailed summary

  • In charts/abstract-node/templates/service.yaml:

    • Changed condition from .Values.global.metrics.enabled to or .Values.global.metrics.enabled .Values.metrics.enabled.
  • In charts/abstract-node/templates/service-core.yaml:

    • Changed condition from .Values.global.metrics.enabled to or .Values.global.metrics.enabled .Values.metrics.enabled.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant