Skip to content

docs: explain notification firebase mode for local push - #275

Merged
sleidig merged 1 commit into
mainfrom
docs/notification-firebase-mode
Nov 5, 2026
Merged

sleidig merged 1 commit into
mainfrom
docs/notification-firebase-mode

Conversation

@Abhinegi2

Copy link
Copy Markdown
Member

The local developer setup only mentioned the Firebase credential for push notifications. Push sending also needs FEATURES_NOTIFICATIONAPI_MODE=firebase (ConditionalOnNotificationFirebaseMode, matchIfMissing = false): without it, devices still register, but nothing is sent and POST /v1/notification/message/device-test returns 404.

This adds the mode to docs/developer/.env.example, commented out next to the credential, and explains both settings in the developer README. It stays commented out because FirebaseConfiguration decodes the credential on startup, so the placeholder value would stop the service from starting.

Testing

Docs only. Checked on the local stack with a real Firebase credential: without the mode the test endpoint returned 404; with FEATURES_NOTIFICATIONAPI_MODE=firebase a test push was delivered to the browser.

The developer .env.example and README only mentioned the Firebase
credential for push notifications. Without
FEATURES_NOTIFICATIONAPI_MODE=firebase the push beans are not created:
devices still register, but no push is sent and the test endpoint
returns 404.

The mode stays commented out in .env.example, because the service
decodes the credential on startup and fails with the placeholder value.
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Abhinegi2 Abhinegi2 self-assigned this Oct 30, 2026
@sleidig
sleidig enabled auto-merge (squash) November 5, 2026 10:24
@sleidig
sleidig disabled auto-merge November 5, 2026 10:24
@sleidig
sleidig merged commit 4fb8939 into main Nov 5, 2026
8 checks passed
@sleidig
sleidig deleted the docs/notification-firebase-mode branch November 5, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants