Repository navigation
docs: explain notification firebase mode for local push - #275
Merged
Merged
Conversation
The developer .env.example and README only mentioned the Firebase credential for push notifications. Without FEATURES_NOTIFICATIONAPI_MODE=firebase the push beans are not created: devices still register, but no push is sent and the test endpoint returns 404. The mode stays commented out in .env.example, because the service decodes the credential on startup and fails with the placeholder value.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
sleidig
approved these changes
Nov 5, 2026
sleidig
enabled auto-merge (squash)
November 5, 2026 10:24
sleidig
disabled auto-merge
November 5, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local developer setup only mentioned the Firebase credential for push notifications. Push sending also needs
FEATURES_NOTIFICATIONAPI_MODE=firebase(ConditionalOnNotificationFirebaseMode,matchIfMissing = false): without it, devices still register, but nothing is sent andPOST /v1/notification/message/device-testreturns 404.This adds the mode to
docs/developer/.env.example, commented out next to the credential, and explains both settings in the developer README. It stays commented out becauseFirebaseConfigurationdecodes the credential on startup, so the placeholder value would stop the service from starting.Testing
Docs only. Checked on the local stack with a real Firebase credential: without the mode the test endpoint returned 404; with
FEATURES_NOTIFICATIONAPI_MODE=firebasea test push was delivered to the browser.