fix(connector): a placeholder API key is not a connection#271
Merged
Conversation
The seeded api_key entries ship placeholders — {"Authorization": "Bearer
<STRIPE_KEY>"} — and is_connected used bool(headers), so a connector with no
key at all reported "Connected via API key". #270 made this visible by
repairing github to api_key: the card immediately claimed Connected while
holding the literal string "<GITHUB_TOKEN>".
Same class of lie as the old Hugging Face "Connected", one step removed.
A header value containing <...> is a placeholder, not a key.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught in the live output right after #270 deployed:
GitHub holds the literal string
"Bearer <GITHUB_TOKEN>".is_connectedusedbool(headers), so a placeholder counted as configured and the card claimed "Connected via API key" with no key at all.Same class of lie as the old Hugging Face "Connected", one step removed. #270 didn't create it — stripe shipped with
"Bearer <STRIPE_KEY>"and would have claimed Connected the moment it was enabled — but repairing github to api_key made it visible.A header value containing
<…>is a placeholder, not a key.Bearer <GITHUB_TOKEN>Bearer <STRIPE_KEY>Bearer ghp_realvalue123X-Note: a>bManifest regenerated.