test(ask_user): de-flake two CI-timing failures (unblocks #237)#238
Merged
Conversation
…237) PR #237 (a harmless ruff version bump) went red on CI/smoke with two failures that have nothing to do with ruff — both pass in isolation and are pre-existing timing flakes: * test_deadline_timeout: `assert len(timeouts) == 1` saw 2. ask() is synchronous and finalizes exactly one timeout per call, so the extra event came from a background-threaded ask() in a NEIGHBOURING test finalizing late into this test's audit log (_log_event reads the log path live at write-time). Now scoped: count only emit/timeout events whose extra.pending_question_id is THIS test's qid. * test_round_trip: "notification not written". ask() writes the pending record and the notification as two separate writes; the test polled for the record then asserted on the notification, which can lag under load. Now polls for the notification too. Both are test-only changes; runtime code untouched. Verified: the two tests pass 10/10 under repeated runs; full suite 2497 passed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing timing flakes (pass in isolation, unrelated to the ruff bump in #237) scoped to their own question-id / polled for the lagging write. Test-only. 10/10 stable, full suite 2497 passed.