Skip to content

Adding publish mode and handling to pelita tournament#903

Open
Debilski wants to merge 5 commits into
ASPP:mainfrom
Debilski:feature/webtournament
Open

Adding publish mode and handling to pelita tournament#903
Debilski wants to merge 5 commits into
ASPP:mainfrom
Debilski:feature/webtournament

Conversation

@Debilski

Copy link
Copy Markdown
Member

Still a draft. Will attempt to merge once the frontend is in a usable (= usable by other people than myself) state.

@Debilski Debilski force-pushed the feature/webtournament branch from cfeb924 to 5a7f389 Compare September 11, 2025 21:19
@Debilski Debilski force-pushed the feature/webtournament branch 2 times, most recently from ad3043e to 7d1232e Compare September 22, 2025 22:17
@Debilski Debilski force-pushed the feature/webtournament branch 3 times, most recently from 5def845 to b8b1b77 Compare April 17, 2026 09:50
@Debilski Debilski force-pushed the feature/webtournament branch from b8b1b77 to c8c1160 Compare April 17, 2026 09:51
@Debilski

Debilski commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

Ready for a first review (in conjunction with https://github.com/ASPP/pelita-webtournament ).

tl;dr

docker run -p 3000:3000 debilski/pelita-webtournament

Open in a browser: http://localhost:3000/

Go to: Live tournament → Single game

run pelita --http-post http://localhost:3000/api/collect --stop-at 0

Works over the network but obviously profits from a fast connection. Multiple computers can watch at the same time. Few minor graphic bugs are known to the author. More explanation to follow :)

@Debilski Debilski marked this pull request as ready for review April 17, 2026 15:22
@Debilski

Copy link
Copy Markdown
Member Author

Closes #574.

@Debilski Debilski changed the title WIP: Adding publish mode and handling to pelita tournament Adding publish mode and handling to pelita tournament Apr 20, 2026
@otizonaizit

Copy link
Copy Markdown
Member

Ouch, I tried to review the changes, but I am a bit overwhelmed... any chance that this could be either split out as the ci_engine, so that is almost does not affect pelita main, or otherwise I think I would need to be hand held in understanding what is happening and some docs will have to be added somewhere...

@Debilski

Debilski commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

Ah, yes, I had already started a longer document with the reasoning behind choosing httpx here (and why I chose it over zmq) but I forgot to finish it.
But then again, in this PR there are basically only two changes. One is adding some metadata object in the tournament that can be serialised to a viewer; the other is just a new viewer class POSTPublisher to have Pelita make POST requests with the current game state to some URL. Not sure if there is actually much to split out here.

@otizonaizit

Copy link
Copy Markdown
Member

So maybe you could add a little comment in the code to explain why httpx? And why it is imported within the class and not at the module level? Also maybe put in the docs of the new class an explanation of its purpose (to publish on th etournament website or whatever)?
I am thinking about us looking back at this in 3 years and wondering what this is all about.

@Debilski

Debilski commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

I’ll postpone the answer (and merge) slightly: I’ve just had another idea come up that I wanted to test first before the write up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants