Adding publish mode and handling to pelita tournament#903
Conversation
cfeb924 to
5a7f389
Compare
ad3043e to
7d1232e
Compare
5def845 to
b8b1b77
Compare
b8b1b77 to
c8c1160
Compare
|
Ready for a first review (in conjunction with https://github.com/ASPP/pelita-webtournament ). tl;dr Open in a browser: http://localhost:3000/ Go to: Live tournament → Single game Works over the network but obviously profits from a fast connection. Multiple computers can watch at the same time. Few minor graphic bugs are known to the author. More explanation to follow :) |
|
Closes #574. |
|
Ouch, I tried to review the changes, but I am a bit overwhelmed... any chance that this could be either split out as the ci_engine, so that is almost does not affect pelita main, or otherwise I think I would need to be hand held in understanding what is happening and some docs will have to be added somewhere... |
|
Ah, yes, I had already started a longer document with the reasoning behind choosing httpx here (and why I chose it over zmq) but I forgot to finish it. |
|
So maybe you could add a little comment in the code to explain why httpx? And why it is imported within the class and not at the module level? Also maybe put in the docs of the new class an explanation of its purpose (to publish on th etournament website or whatever)? |
|
I’ll postpone the answer (and merge) slightly: I’ve just had another idea come up that I wanted to test first before the write up. |
Still a draft. Will attempt to merge once the frontend is in a usable (= usable by other people than myself) state.