Skip to content

Update reusable actions to use OIDC #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jacquelynsmale wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Update reusable actions to use OIDC #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/reusable-docker-ecr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ on:
required: false
default: Dockerfile
type: string
secrets:
AWS_ACCESS_KEY_ID:
required: true
AWS_SECRET_ACCESS_KEY:
required: true

concurrency:
group: ${{ inputs.version_tag }}
Expand All @@ -28,6 +23,7 @@ concurrency:
jobs:
dockerize:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6
with:
Expand All @@ -37,15 +33,15 @@ jobs:
run: |
echo "CI_JOB_TIMESTAMP=$(date --utc --rfc-3339=seconds)" >> $GITHUB_ENV

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: arn:aws:iam::${{ secrets.AWS_ROLE_ARN }}
aws-region: ${{env.AWS_DEFAULT_REGION}}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4

- uses: aws-actions/configure-aws-credentials@v6
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ inputs.aws_region }}

- name: Login to Amazon ECR
uses: aws-actions/amazon-ecr-login@v2

Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,15 +174,15 @@ jobs:
needs: call-version-info-workflow
uses: ASFHyP3/actions/.github/workflows/reusable-docker-ecr.yml@v0.21.1
permissions:
id-token: write
contents: read
with:
version_tag: ${{ needs.call-version-info-workflow.outputs.version_tag }}
ecr_registry: 845172464411.dkr.ecr.us-west-2.amazonaws.com
aws_region: us-west-2 # Optional; default shown
file: Dockerfile # Optional; default shown
file: Dockerfile # Optional; default show
secrets:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN }}
```

### [`reusable-docker-ghcr.yml`](./.github/workflows/reusable-docker-ghcr.yml)
Expand Down
Loading