-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update dependency go to 1.26.x #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.20.x | ||
| go-version: 1.26.x | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. golangci-lint v1.52 incompatible with Go 1.26High Severity The |
||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Run linters | ||
|
|
@@ -46,7 +46,7 @@ jobs: | |
| if: success() | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.20.x | ||
| go-version: 1.26.x | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Calc coverage | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test matrix Go version not updated to 1.26.x
High Severity
The
lintandcoveragejobs were updated to Go1.26.x, but thetestjob matrix at line 28 still usesgo-version: [1.20.x]. This means tests run against Go 1.20 while linting and coverage run against Go 1.26, creating a version mismatch. Tests won't validate the code against the intended Go version, and any Go 1.26-specific behavior or incompatibilities will go undetected.Additional Locations (1)
.github/workflows/test.yml#L48-L49