Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.20.x
go-version: 1.26.x

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test matrix Go version not updated to 1.26.x

High Severity

The lint and coverage jobs were updated to Go 1.26.x, but the test job matrix at line 28 still uses go-version: [1.20.x]. This means tests run against Go 1.20 while linting and coverage run against Go 1.26, creating a version mismatch. Tests won't validate the code against the intended Go version, and any Go 1.26-specific behavior or incompatibilities will go undetected.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint v1.52 incompatible with Go 1.26

High Severity

The lint job now uses Go 1.26.x but still pins golangci-lint to v1.52 (line 23). golangci-lint only supports Go versions up to the version it was compiled with, and v1.52 was built with Go ~1.20. It cannot parse or analyze Go 1.26 code, so the lint CI job will fail.

Fix in Cursor Fix in Web

- name: Checkout code
uses: actions/checkout@v4
- name: Run linters
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
if: success()
uses: actions/setup-go@v5
with:
go-version: 1.20.x
go-version: 1.26.x
- name: Checkout code
uses: actions/checkout@v4
- name: Calc coverage
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_assets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.20.x
go-version: 1.26.x
- name: Checkout code
uses: actions/checkout@v4
- name: build
Expand Down
Loading