fix(server-args): keep +custom_ops JSON valid across variant composition - #1315
Open
hmahmad26 wants to merge 1 commit into
Open
fix(server-args): keep +custom_ops JSON valid across variant composition#1315hmahmad26 wants to merge 1 commit into
hmahmad26 wants to merge 1 commit into
Conversation
POSIX shlex.split stripped quotes from --compilation-config, and the bareword repair could not re-quote +fused_rms_norm_gated, so every variant died at vLLM argv parse. Tokenize quote-preservingly and accept an optional leading + or - on JSON barewords. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shlex.split, which stripped inner JSON quotes from--compilation-config.+fused_rms_norm_gated(+was outside the charset), so variants died at argv parse withInvalid JSON: key must be a stringwhile baseline (which does not go throughcompose_server_args) stayed valid.remove_server_args, accept an optional leading+/-on JSON barewords, and log if composition still damages a JSON flag.Test plan
+fused_rms_norm_gatedsurvivesremove_server_args/compose_server_argsin append, replace, and flag-removal modes'kimi_k3'wrappers are stripped so Magpie does not see them on argvtest_sign_prefixed_custom_op_survives_removal,test_compose_preserves_json_for_every_args_mode,test_shell_quoted_plain_operand_loses_its_wrappersMade with Cursor