Add additive SBD V6 metadata and timeline projection - #1313
Closed
luochen-amd wants to merge 4 commits into
Closed
Conversation
CI E2E report — ❌ Timeout
|
luochen-amd
force-pushed
the
feat/sbd-v6-metadata-outcome-timeline
branch
from
August 28, 2026 02:50
4dd5533 to
f09e319
Compare
Contributor
Author
|
Addressed the three blocking review findings:
Regression coverage now includes hard preflight failure persistence, fresh-to-resume event retention, legacy event migration, and Kernel Explore exclusion. Local validation:
|
|
|
||
|
|
||
| def test_preflight_hard_failure_creates_session_and_final_sbd(tmp_path, monkeypatch): | ||
| import hyperloom.inference_optimizer.cli as optimizer_cli |
|
|
||
|
|
||
| def test_unwrapped_preflight_failure_is_persisted_as_failed(tmp_path, monkeypatch): | ||
| import hyperloom.inference_optimizer.cli as optimizer_cli |
|
|
||
|
|
||
| def test_busy_resume_preflight_failure_uses_isolated_session(tmp_path, monkeypatch): | ||
| import hyperloom.inference_optimizer.cli as optimizer_cli |
Contributor
Author
|
This combined PR has been split to keep the review boundaries explicit:
The Framework branch is intentionally kept separate while #1301 and #1331 are still open. A focused Framework PR can be opened after the dependency bases are aligned, avoiding duplicate core changes in review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata,outcome,timeline, and top-levelclosedatainstallandmodel_gatetelemetry without changing preflight, gate, or resume outcomesframework_agenttimeline for configuration, source, Critic, macro-cycle, exit, and failure evidenceReview Fixes
framework_agenttimeline creationCompatibility
Validation
git diff --checkpassedEnvironment Note
fcntlcompatibility module so POSIX-only KB imports can load; the production lock behavior remains covered by Linux CI and the focused busy-session test uses an explicit lock double