Repository navigation
MoE: native FP8 QAT for routed-expert GMMs (FP8 forward + FP8-weight backward dLHS) #5969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,602
−54
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0bf1938
MoE: native FP8 QAT for routed-expert GMMs (FP8 forward + FP8-weight …
shuningjin 10fdc4f
Address review: fixed native-forward numerics, fixed-tile requirement…
shuningjin 22ebd03
Enforce single K tile for full-K dynamic LHS quantization in fp8_moe_…
shuningjin 77cc0ac
Reject split K for fp8_moe_native_fwd; cache rhs_contract_dequant blo…
shuningjin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: When tensor parallelism shards wo's K dimension,
_moe_mlp_dim_if_unsharded()returns None and this tile check is skipped. A tile equal to the per-shard size would then pass here and inmake_gmm_configs, so each TP shard would quantize its activation with its own scale instead of one scale over the full K. Please rejectfp8_moe_native_fwdwhen any axis sharding the MoE MLP dim (tensor, tensor_sequence, autoregressive, or anything mlp_no_fsdp maps to) has parallelism ≠ 1, and add a matching guard in moe.py wherewo_pspecis built.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! Addressed in 77cc0ac.
fp8_moe_native_fwdnow rejects a split K instead of skipping the tile check: at config time whentensor/tensor_sequence/autoregressive(or any axismlp_no_fsdpmaps to) has parallelism > 1, and likewise for wi's K (embed dim) andnum_moe_emb_chunks > 0.custom_mesh_and_ruleand-1parallelism are covered too.