Skip to content

[*] pre-commit run --all-files - #2498

Merged
copybara-service[bot] merged 1 commit into
AI-Hypercomputer:mainfrom
SamuelMarks:pre-commit-running
Nov 13, 2025
Merged

[*] pre-commit run --all-files#2498
copybara-service[bot] merged 1 commit into
AI-Hypercomputer:mainfrom
SamuelMarks:pre-commit-running

Conversation

@SamuelMarks

@SamuelMarks SamuelMarks commented Oct 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Run the pre-commit hook across the whole codebase and then fixed any issues found. Also fixed the CI to run the pre-commit hook properly and then renamed to reflect its telos.

Tests

$ pre-commit run --all-files

Install https://pre-commit.com with pip install pre-commit

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@SamuelMarks
SamuelMarks marked this pull request as draft October 14, 2025 18:23
@SamuelMarks
SamuelMarks marked this pull request as ready for review October 14, 2025 18:44
bvandermoon
bvandermoon reviewed Oct 17, 2025
View reviewed changes
Comment thread .pre-commit-config.yaml Outdated
bvandermoon
bvandermoon reviewed Oct 17, 2025
View reviewed changes
Comment thread benchmarks/api_server/server_models.py Outdated
Comment thread src/MaxText/examples/grpo_llama3_1_70b_demo_pw.py Outdated
Comment thread src/MaxText/examples/grpo_llama3_1_70b_demo_pw.py Outdated
Comment thread src/MaxText/examples/grpo_llama3_1_70b_demo_pw.py Outdated
@SamuelMarks
SamuelMarks force-pushed the pre-commit-running branch 2 times, most recently from 1963d7e to d78b119 Compare November 13, 2025 00:42
@SamuelMarks SamuelMarks reopened this Nov 13, 2025
@SamuelMarks
SamuelMarks force-pushed the pre-commit-running branch 3 times, most recently from 2337339 to 3f5e73a Compare November 13, 2025 04:12
shralex
shralex requested changes Nov 13, 2025
View reviewed changes
Comment thread benchmarks/api_server/server_models.py Outdated
Comment thread .github/workflows/QA.yml Outdated
@SamuelMarks
SamuelMarks force-pushed the pre-commit-running branch 10 times, most recently from 2fbc047 to a540257 Compare November 13, 2025 07:50
@SamuelMarks
[*] pre-commit run --all-files success ; [.github/workflows/CPUTest…
4c3fd67 
…s.yml -> .github/workflows/CodeQuality.yml] Run pre-commit hooks and only against the changed files rather than whole codebase; rename to refer to actual task being performed
@copybara-service
copybara-service Bot merged commit 59b37eb into AI-Hypercomputer:main Nov 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shralex shralex shralex approved these changes
@A9isha A9isha A9isha approved these changes
@bvandermoon bvandermoon bvandermoon approved these changes
@SujeethJinesh SujeethJinesh Awaiting requested review from SujeethJinesh SujeethJinesh is a code owner
@richjames0 richjames0 Awaiting requested review from richjames0
@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner
@mitalisi mitalisi Awaiting requested review from mitalisi mitalisi is a code owner
@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner
@shauryagup shauryagup Awaiting requested review from shauryagup shauryagup is a code owner
@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner
@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner
@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner
@jacoguzo jacoguzo Awaiting requested review from jacoguzo
@gagika gagika Awaiting requested review from gagika gagika is a code owner
@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner
@michelle-yooh michelle-yooh Awaiting requested review from michelle-yooh
@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner
@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner
@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner
@suexu1025 suexu1025 Awaiting requested review from suexu1025
@parambole parambole Awaiting requested review from parambole parambole is a code owner
@jshin1394 jshin1394 Awaiting requested review from jshin1394
@liudangyi liudangyi Awaiting requested review from liudangyi
@NicoGrande NicoGrande Awaiting requested review from NicoGrande
@Obliviour Obliviour Awaiting requested review from Obliviour Obliviour is a code owner

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SamuelMarks @shralex @A9isha @bvandermoon