Repository navigation
Cherry-pick upstream commits for parallelio , py-pyyaml and roms - #11
Merged
Merged
Conversation
* parallelio: add patch for libfind * support libraries installed through apt into lib/CMAKE_LIBRARY_ARCHITECTURE * parallelio: add new versions, cleanup patch * add versions 2.6.7, 2.6.9, 2.6.10 * add comment for cmake-libfind-arch.patch and apply to more versions
Signed-off-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
aidanheerdegen
previously approved these changes
Sep 28, 2026
aidanheerdegen
left a comment
aidanheerdegen
left a comment
Member
There was a problem hiding this comment.
Seems fine to me, but note it does not contain any changes related to roms.
harshula
force-pushed
the
access/v1.1-next
branch
from
September 28, 2026 07:10
7cb487e to
e084054
Compare
harshula
changed the title
aidanheerdegen
approved these changes
Sep 28, 2026
aidanheerdegen
left a comment
aidanheerdegen
left a comment
Member
There was a problem hiding this comment.
I'm approving, because there is definitely value in having this available, but I am not convinced that we can use this as-is when deploying models.
| custom_app_name = os.path.splitext(os.path.basename(custom_app))[0] | ||
|
|
||
| # Copy custom header to ROMS/Include directory | ||
| copy(custom_app, join_path("ROMS", "Include", "{0}.h".format(custom_app_name))) |
Member
There was a problem hiding this comment.
My concern is that this an arbitrary path that is not under source control or under the provenance umbrella of spack.
Collaborator
Author
There was a problem hiding this comment.
Hi @aidanheerdegen , I suspect this discussion should be elsewhere? Perhaps in https://github.com/ACCESS-NRI/CoastRI-ROMS ?
CodeGat
approved these changes
Sep 29, 2026
Collaborator
Author
|
The four failures are due to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom_applicationbuilds for ROMS model access-spack-packages#511