Repository navigation
Infra Update v4 for Special Repos: Support spack.repos, Add Tiered Common Configuration Via spack.include - #10
Merged
Merged
Conversation
CodeGat
force-pushed
the
infra-v4
branch
2 times, most recently
from
September 21, 2026 05:32
5c512f4 to
69caf2d
Compare
…in config that points to the caller builtin repo
…recedence than builtin
harshula
approved these changes
Sep 29, 2026
harshula
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed with the help of Claude Opus 5.5 via Zoom VC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Note
This PR incorporates major
build-cichanges into this repository, due to the deprecation ofinputs.*-spack-packages-refandinputs.spack-manifest-data-pathBackground
More info and motivations in the linked issue, but essentially:
inputs.*-spack-packages-refin favor of in-manfiestspack.repossection, like MDRs. By default, it will use the PR branch foraccess-spack-packages, and the latestaccess/v1.1forbuiltinspack packages. This can be changed via localspack-configconfig specified in.github/build-ci/config, or alternatively in this repository itself!inputs.spack-manifest-data-pathin favor of tiered configuration viaspack.include.The two main entrypoints will work as follows with this update:
PR Workflow
builtinspack packages repo: will use the PR branch as normal, viabuild-ciusing the caller repo as the builtin (see the.github/build-ci/config/section).access-spack-packagesrepo: Will useapi-v2branch by default. To use a different branch, edit.github/build-ci/config/repos.yamland add aaccess_spack_packagesentry like so:Workflow Dispatch
builtinspack packages repo: Will need to useUse workflow from...dropdown, picking the appropriate builtin branch or tag.access-spack-packagesrepo: Will need to useUse workflow from...dropdown, picking the appropriate ASP branch or tag, in which a.github/build-ci/config/repos.yamlis edited to use a differentaccess_spack_packagesref. See above for an example.The PR
inputs.spack-manifest-data-pathvalues and inline them into manifests. Delete.github/build-ci/data/standard.json.inputs.*-spack-packages-ref, using the local ASP config to set those values..github/build-ci/configso PRs from this repo use the PR branch, rather than the defaultaccess/v1.1branch. See Basespack.includes forbuild-ciaccess-spack-packages#486 for more info on caller configuration.Testing
Tested in https://github.com/ACCESS-NRI/upstream-spack-packages/actions/runs/35689962216?pr=10 - all packages succeeded except for https://github.com/ACCESS-NRI/upstream-spack-packages/actions/runs/35689962216/job/106626312258?pr=10, this was due to it being excluded in the CICE repo but not upstream.