Gracefully handle context event - #314
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request require the following changes: AnatomicMaps/flatmap-viewer#66
This pull request will handle context lost and provide a way to restore it.
Context will be forced to stop when changing the flatmap using the map selector, the context will be restored once that map is brought back and restore all previous state (beside filter, that is handled by map-viewer.)
I have made some changes on minimap as well and make sure it is only rendered after the map is ready.
It also add a new flatmap error message to allow user to manually restore the context which will support some edge cases in map-viewer such as opening too many flatmapvuers causing current active map to lose context.