Repository navigation
Filter ferrum 0.18's stack-frame lines out of the console log - #37
Merged
Merged
Conversation
ConsoleLogger filtered Ferrum's CDP frames by prefix. ferrum 0.18 also logs one " at fn (url:line:col)" line per stack frame of a console call, which went unfiltered to #warn — and action_text_spec stubs `warn` with a matcher, so the extra lines raise MockExpectationError on Ferrum's subscriber thread, killing it and failing every later js example. The lockfile still pins cuprite 0.17, so this lands before the bump rather than as a cascading, unrelated-looking failure on a dependency PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsoleLoggerfiltered Ferrum's CDP protocol frames by prefix. ferrum 0.18 alsologs one
at fn (url:line:col)line per stack frame of a console call, and thosewent unfiltered to
#warn.That matters here because
action_text_spec.rb:18stubswarnwith a matcher:A
.with(matcher)stub rejects any other argument, and the stack-frame lines arriveon Ferrum's own subscriber thread — so the resulting
MockExpectationErroris raisedthere, killing the thread and failing every later
js: trueexample.The lockfile still pins
cuprite 0.17→ferrum 0.17.2, so the suite is green today.Dependabot watches the root Gemfile, so the next cuprite minor would land this as a
cascading, unrelated-looking JS failure on a dependency PR. Cheaper before than after.
ConsoleLoggeris a pure function, so it now has direct coverage — including a caseproving an ordinary message that merely mentions a stack frame is still forwarded,
so the filter cannot swallow real output.
Closes #33