Skip to content

Update Rack gem to latest 3.0.x - #11882

Merged
aduth merged 2 commits into
mainfrom
aduth-rack-3-1
Feb 14, 2025
Merged

Update Rack gem to latest 3.0.x#11882
aduth merged 2 commits into
mainfrom
aduth-rack-3-1

Conversation

@aduth

@aduth aduth commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

🛠 Summary of changes

Updates the Rack gem to the latest version.

Changelog: https://github.com/rack/rack/blob/main/CHANGELOG.md

Note that the 3.1.0 release includes a number of breaking changes, though upon review, there does not appear to be any changes impacting our current usage. Edit: After incompatibilities observed, the changes now upgrade to the latest security release in the 3.0.x line instead.

📜 Testing Plan

Verify build passes.

Verify make audit produces no security advisories output after running bundle install.

changelog: Internal, Dependencies, Update dependency to resolve security advisory
@aduth
aduth requested a review from a team February 14, 2025 14:56
@solipet
solipet self-requested a review February 14, 2025 15:48

@solipet solipet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple enough change, but somehow it is breaking tons (all?) of the feature specs!

@aduth

aduth commented Feb 14, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, there seems to be some incompatibility with capybara-webmock or webmock. I'm digging into it, but may end up going back to the (patched) 3.0.x if it doesn't pan out.

@aduth

aduth commented Feb 14, 2025

Copy link
Copy Markdown
Contributor Author

The underlying issue seems to be with capybara-webmock gem using an outdated reference to Rack::Handler, which was extracted to a separate gem in Rack 3. Unclear why this works in 3.0.x and not 3.1.x. (Edit: Likely related to rack/rack@fd7e0ad)

There's a related pull request at hashrocket/capybara-webmock#56

In the meantime, in 8b2f93f I've downgraded to the version on the 3.0.x line with the patch.

@aduth aduth changed the title Update Rack gem to latest 3.1.x Update Rack gem to latest 3.0.x Feb 14, 2025
@aduth
aduth merged commit 5bc4223 into main Feb 14, 2025
@aduth
aduth deleted the aduth-rack-3-1 branch February 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants