Skip to content

fix(i18n): resolve translation warnings in make-pot #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipeelia merged 3 commits into from
Jul 23, 2026
+9 −8
Merged

fix(i18n): resolve translation warnings in make-pot #4323

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2df40dc
fix(i18n): resolve translation warnings in make-pot
faisalahammad Jun 19, 2026
412bb6e
fix(i18n): use _x() with context disambiguation in control.js
faisalahammad Jul 6, 2026
2a8bd81
fix(i18n): match translator comments to name count
faisalahammad Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions assets/js/features/components/control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
} from '@wordpress/components';
import { safeHTML } from '@wordpress/dom';
import { RawHTML, WPElement } from '@wordpress/element';
import { _n, __, sprintf } from '@wordpress/i18n';
import { _n, __, _x, sprintf } from '@wordpress/i18n';

/**
* Internal dependencies.
Expand Down Expand Up @@ -162,15 +162,15 @@ const Control = ({
}
if (titles.length === 2) {
return sprintf(
/* translators: %1$s: first feature name, %2$s: second feature name */
__('%1$s and %2$s', 'elasticpress'),
/* translators: %1$s: feature name(s), %2$s: last feature name */
_x('%1$s and %2$s', 'two feature names', 'elasticpress'),
Comment thread
faisalahammad marked this conversation as resolved.
Outdated
titles[0],
titles[1],
);
}
return sprintf(
/* translators: %1$s: comma-separated list of feature names, %2$s: last feature name */
__('%1$s and %2$s', 'elasticpress'),
/* translators: %1$s: feature name(s), %2$s: last feature name */
Comment thread
faisalahammad marked this conversation as resolved.
Outdated
_x('%1$s and %2$s', 'multiple feature names', 'elasticpress'),
Comment thread
faisalahammad marked this conversation as resolved.
Outdated
titles.slice(0, -1).join(__(', ', 'elasticpress')),
titles[titles.length - 1],
);
Expand Down
1 change: 1 addition & 0 deletions assets/js/instant-results/components/results/pagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ const Pagination = ({ offset, onNext, onPage = {}, onPrevious, perPage, total })
}
}}
aria-current={isCurrent ? 'page' : undefined}
/* translators: %d: Page number. */
aria-label={sprintf(__('Page %d', 'elasticpress'), page.value)}
>
{page.value}
Expand Down
6 changes: 3 additions & 3 deletions assets/js/synonyms/apps/synonyms-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export default () => {
title: (
<GroupTab isValid={!synonyms.some((s) => !s.valid)}>
{
/* translators: Synonyms count */
/* translators: %d: Number of synonyms. */
sprintf(__('Synonyms (%d)', 'elasticpress'), synonyms.length)
}
</GroupTab>
Expand All @@ -94,7 +94,7 @@ export default () => {
title: (
<GroupTab isValid={!hyponyms.some((s) => !s.valid)}>
{
/* translators: Hyponyms count */
/* translators: %d: Number of hyponyms. */
sprintf(__('Hyponyms (%d)', 'elasticpress'), hyponyms.length)
}
</GroupTab>
Expand All @@ -105,7 +105,7 @@ export default () => {
title: (
<GroupTab isValid={!replacements.some((s) => !s.valid)}>
{
/* translators: Replacements count */
/* translators: %d: Number of replacements. */
sprintf(__('Replacements (%d)', 'elasticpress'), replacements.length)
}
</GroupTab>
Expand Down
Loading