-
Notifications
You must be signed in to change notification settings - Fork 72
Rotate "upgrade" Safe{Wallet} owners in preparation for the Guard #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+7
−5
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cbd5543
Replace Will with Chris as a signer on the upgrade Safe{Wallet}
duncancmt 80da276
Add Phil as a signer on the upgrade Safe{Wallet} and configure it as …
duncancmt 5f96b89
Merge branch 'master' into dcmt/safe-chores
duncancmt 6af3fd1
Robinhood is no longer private, so the explorer can be in the public …
duncancmt 3b879cd
Add timeout for Duncan's slow signing to `deploy_safeguard.sh`
duncancmt 614a134
Merge branch 'dcmt/safe-v1.4.1' into dcmt/safe-chores
duncancmt 9df8a55
Fix `cast send` command line
duncancmt 859e661
Merge branch 'dcmt/safe-v1.4.1' into dcmt/safe-chores
duncancmt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,12 +104,12 @@ library SafeConfig { | |
| revert(string.concat("Unrecognized chainid ", ItoA.itoa(block.chainid))); | ||
| } | ||
|
|
||
| uint256 internal constant upgradeSafeThreshold = 2; | ||
| uint256 internal constant upgradeSafeThreshold = 3; | ||
| uint24 internal constant upgradeSafeTimelockDelay = 5 days; | ||
|
|
||
| function getUpgradeSafeSigners() internal view returns (address[] memory) { | ||
| address[] memory result = new address[](4); | ||
| result[0] = 0x257619B7155d247e43c8B6d90C8c17278Ae481F0; // Will | ||
| address[] memory result = new address[](5); | ||
| result[0] = 0x203393921A2E778fCB8619470ee0Cf399b6Ab4b2; // Chris | ||
| result[1] = 0x3C3a57b5CC72933E312e0b0bEBe031F72d47c30B; // Duncan | ||
| if (_isMainnet()) { | ||
| result[2] = 0x5ee2a00F8f01d099451844Af7F894f26A57FCbF2; // Amir | ||
|
|
@@ -118,6 +118,7 @@ library SafeConfig { | |
| result[2] = 0x9E4496adE6096b000C856219C27734F4f89A5210; // Amir | ||
| result[3] = 0x5A9d540A07a96a2bfC8a8dfd638359778C72526f; // Jacob | ||
| } | ||
| result[4] = 0xc3445Ec2E12Ba39E74922bD33559028985164bb4; // Phil | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. confirmed ✅ |
||
| return result; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed