Skip to content

Add SafeGuard deployment script - #597

Merged
e1Ru1o merged 12 commits into
masterfrom
e1Ru1o/safe-guard-deployment
Jul 23, 2026
Merged

Add SafeGuard deployment script#597
e1Ru1o merged 12 commits into
masterfrom
e1Ru1o/safe-guard-deployment

Conversation

@e1Ru1o

@e1Ru1o e1Ru1o commented Jul 10, 2026

Copy link
Copy Markdown
Member

No description provided.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@e1Ru1o e1Ru1o self-assigned this Jul 10, 2026
@e1Ru1o
e1Ru1o requested a review from duncancmt as a code owner July 10, 2026 16:30
@immunefi-magnus

Copy link
Copy Markdown

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

@duncancmt duncancmt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably build on top of #590 . Also some of the changes from https://github.com/0xProject/0x-settler/tree/dcmt/safe-v1.4.1-installation may be useful. Feel free to merge them or to cherry-pick them, as you see fit

Otherwise, looks pretty good!

Comment thread sh/deploy_safeguard.sh
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh
Comment thread sh/deploy_safeguard.sh Outdated
e1Ru1o and others added 2 commits July 13, 2026 20:29
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@e1Ru1o

e1Ru1o commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Atm I am not using anything from the safe field in the script even after resolving your comments, so if we don't change the behavior to be more like your branch safe-v1.4.1-installation branch, I don't think I need to rebase #590. I see though that installation branch has some good features and does simulation to check that the Guard really works. I am fine using your installation branch, they handle in different ways forge versions but I am fine with any of the two.

As your is more feature extensive, consider opening a PR, I can close this one and do a follow up PR on top of yours with any changes I would recommend.

duncancmt and others added 6 commits July 13, 2026 21:04
… product.

Co-Authored-By: Codex <codex@openai.com>
State, under Critical Reminders, that comments belong only where the code
cannot speak for itself; that a comment explains only its associated code,
never the chat/task/plan/diff; and that comments address behavior and intent
rather than identifiers, justifying only the obtuse or non-idiomatic.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh
Comment thread sh/deploy_safeguard.sh
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh Outdated
Comment thread sh/deploy_safeguard.sh Outdated
e1Ru1o and others added 2 commits July 17, 2026 18:17
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread sh/deploy_safeguard.sh
Comment thread sh/deploy_safeguard.sh Outdated
@e1Ru1o
e1Ru1o requested a review from duncancmt July 23, 2026 13:22
@e1Ru1o
e1Ru1o merged commit 4a2639a into master Jul 23, 2026
4 checks passed
@e1Ru1o
e1Ru1o deleted the e1Ru1o/safe-guard-deployment branch July 23, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants