Add RedeploySettlers + revive_chain.sh for reviving abandoned chains - #573
Open
jparklev wants to merge 11 commits into
Open
Add RedeploySettlers + revive_chain.sh for reviving abandoned chains#573jparklev wants to merge 11 commits into
jparklev wants to merge 11 commits into
Conversation
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
Collaborator
Contributor
Author
duncancmt
reviewed
Jul 14, 2026
duncancmt
left a comment
duncancmt
left a comment
Collaborator
There was a problem hiding this comment.
Should deploy_safe_infra.sh also check and deploy v1.4.1?
Does this work like it should on weirdo chains like Tempo?
Comment on lines
+177
to
+179
| if [[ $safe_migration == null ]] ; then | ||
| safe_migration=0x0000000000000000000000000000000000000000 | ||
| fi |
Collaborator
There was a problem hiding this comment.
This doesn't seem like a safe default
| required="$(bc <<<"$gas_price * ${sender_gas[$sender]}")" | ||
| actual="$(cast balance --rpc-url "$rpc_url" "$sender")" | ||
| if (( $(bc <<<"$actual < $required") )) ; then | ||
| echo "Insufficient ETH at $sender ($actual wei, need >= $required wei for ${sender_gas[$sender]} gas)" >&2 |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "Insufficient ETH at $sender ($actual wei, need >= $required wei for ${sender_gas[$sender]} gas)" >&2 | |
| echo "Insufficient native asset at $sender ($actual wei, need >= $required wei for ${sender_gas[$sender]} gas)" >&2 |
| ISafeMigration(safeMigration).SAFE_FALLBACK_HANDLER() == safeFallbackV141, "SafeMigration fallback mismatch" | ||
| ); | ||
|
|
||
| _execTransaction( |
Collaborator
There was a problem hiding this comment.
Shouldn't this use _execDelegateCall?
| safeBytecodes: SafeBytecodes("", "", "", "", "", "", "", "") | ||
| }); | ||
| safeCompatConfig.safeBytecodes.load(vm); | ||
| if (safeCompatConfig.isEraVm) safeCompatConfig.safeBytecodes.loadV141(vm); |
Collaborator
There was a problem hiding this comment.
That's a bit confusing. Why do we only load v1.4.1 when it's EraVm? I think this warrants a comment
Comment on lines
+200
to
+203
| require(predictedTakerSubmittedSettler.code.length == 0, "predicted taker settler slot occupied"); | ||
| require(predictedMetaTxSettler.code.length == 0, "predicted metatx settler slot occupied"); | ||
| require(predictedIntentSettler.code.length == 0, "predicted intent settler slot occupied"); | ||
| require(predictedBridgeSettler.code.length == 0, "predicted bridge settler slot occupied"); |
Collaborator
There was a problem hiding this comment.
This is unnecessarily defensive
Comment on lines
+245
to
+248
| bytes memory takerDeployTx = _wrapSingleMultisend(_encodeMultisend(deployerProxy, takerSubmittedDeployCall)); | ||
| bytes memory metaTxDeployTx = _wrapSingleMultisend(_encodeMultisend(deployerProxy, metaTxDeployCall)); | ||
| bytes memory intentDeployTx = _wrapSingleMultisend(_encodeMultisend(deployerProxy, intentDeployCall)); | ||
| bytes memory bridgeDeployTx = _wrapSingleMultisend(_encodeMultisend(deployerProxy, bridgeDeployCall)); |
Collaborator
There was a problem hiding this comment.
_wrapSingleMultisend seems unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refactoring #564 to be chain-agnostic + support eraVM