Skip to content

miner: skip loop processing and allocations for empty transaction events #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shinobi133 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

miner: skip loop processing and allocations for empty transaction events #2285

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39cc09f
miner: skip loop processing and allocations for empty transaction events
shinobi133 Jun 23, 2026
d809fd3
miner: parallelize cryptographic sender recovery in txs loop
shinobi133 Jun 23, 2026
bf401d5
perf: simplify transaction loop and drop high-overhead warmup goroutines
shinobi133 Jun 24, 2026
9d754c6
fix(miner): preserve LazyTransaction.Resolve semantics and skip empty…
shinobi133 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions miner/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,24 @@ func (w *worker) mainLoop() {
if delay <= 0 {
continue
}
if len(ev.Txs) == 0 {
w.newTxs.Add(0)
continue
}

// Warm up cryptographic sender caches in parallel across cores
var wg sync.WaitGroup
for _, tx := range ev.Txs {
wg.Add(1)
go func(t *types.Transaction) {
defer wg.Done()
if w.current != nil {
types.Sender(w.current.signer, t)
}
}(tx)
}
wg.Wait()

txs := make(map[common.Address][]*txpool.LazyTransaction, len(ev.Txs))
for _, tx := range ev.Txs {
acc, _ := types.Sender(w.current.signer, tx)
Expand Down
Loading