Skip to content

chore: address follow-up comments of CLI typed call output - #2515

Open
juan518munoz wants to merge 2 commits into
nextfrom
jmunoz-call-typed-rendering-followups
Open

chore: address follow-up comments of CLI typed call output#2515
juan518munoz wants to merge 2 commits into
nextfrom
jmunoz-call-typed-rendering-followups

Conversation

@juan518munoz

@juan518munoz juan518munoz commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Closes #2512

  1. Drop CallCode.result_felts: removed the field
  2. An undecodable result no longer aborts the call: print_call_result is now infallible, it prints the decode error.
  3. Fix the untyped-fallback: corrected the comment, it claimed landing there meant the export carried no signature, when in reality a Fast or C lowering covers the case too.
  4. Accept bech32 account IDs as arguments: added codecs::parse_account_id_token to parse both hex or bech32 addresses.
  5. Fold overlapping call.rs unit tests: collapsed some test into one.

@juan518munoz
juan518munoz marked this pull request as ready for review September 8, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI typed call output: followups

1 participant