feat(rust-client): retryable batch submissions with an unknown outcome - #2508
Open
sofiazcoaga wants to merge 4 commits into
Open
feat(rust-client): retryable batch submissions with an unknown outcome#2508sofiazcoaga wants to merge 4 commits into
sofiazcoaga wants to merge 4 commits into
Conversation
sofiazcoaga
added a commit
that referenced
this pull request
Sep 7, 2026
sofiazcoaga
marked this pull request as ready for review
September 7, 2026 18:58
sofiazcoaga
force-pushed
the
feat/batch-indeterminate-submission
branch
from
September 7, 2026 19:19
575fb20 to
d10932d
Compare
juan518munoz
approved these changes
Sep 7, 2026
Comment on lines
+213
to
+217
| .submit_proven_batch( | ||
| submission.proven_batch.clone(), | ||
| (*submission.proposed_batch).clone(), | ||
| sealed_inputs, | ||
| ) |
Collaborator
There was a problem hiding this comment.
I think that we may be able to pass both the proven_batch and proposed_batch as reference, so we prevent cloning. (Same goes for submit_proven_transaction).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A batch submission that comes back without a definite outcome reached the caller as
ClientError::RpcError, indistinguishable from a rejection. The caller could not tell "the node rejected this" from "this may be in the mempool right now", and had nothing left to act on: submit consumes the builder, so theProvenBatchand the per-transaction inputs the submission sealed are dropped with it.Main changes
ProvenBatchSubmission, carrying theProvenBatch, theProposedBatchand theTransactionResults a resend needs. It has no public constructor, so the error below is the only source of one.BatchBuilderError::BatchSubmissionOutcomeUnknownvariant, which carries that payload alongside the originatingRpcError.Client::retry_proven_batch, which resends the payload without executing or proving again, sealing the inputs against the current encryption key on every attempt.Client::new_transaction_batchfromtransaction/mod.rsintobatch/mod.rs, now that a second Client method belongs to the batch module.This PR follows #2498.