Test: code simplifications by juan518munoz · Pull Request #2481 · 0xMiden/rust-sdk

juan518munoz · 2026-09-02T15:41:29Z

Simplifies the integration tests setup by taking leverage of the TestClient struct added on test: run integration test with fees #2455.
Moved loose utility/setup functions for testing into the new type.
Also fixes testing setup for fee-less chains, were the function that loads funder accounts from a file would fail when passing an empty file path.

ricomateo · 2026-09-04T18:56:10Z

+    /// Builds a faucet without the [`BasicWallet`] ride-along, so the account exposes only the
+    /// faucet interface.
+    #[must_use]
+    pub fn bare(mut self) -> Self {
+        self.bare = true;
+        self
+    }


nit: I think we could use a more descriptive name for this setter, like without_basic_wallet_component (we could also rename the corresponding bare field to with_basic_wallet_component and set it to false here), but feel free to disregard.

Renamed as suggested in f4cb0fb

ricomateo · 2026-09-04T20:44:24Z

 * [BREAKING][rust] `Client::remove_address` and `Store::remove_address` return `bool` instead of `()`, reporting whether the address was tracked. When it wasn't, `Client::remove_address` now leaves the derived note tag in place instead of running its cleanup.
 * [BREAKING][type][rust] Added the `TransactionRequestError::ForeignProcedureInputsTooLong` variant ([#2187](https://github.com/0xMiden/rust-sdk/pull/2187)).
 * [BREAKING][behavior][store] The `output_notes` table gained a nullable `script_root` column referencing `notes_scripts`, and note scripts are fully normalized: an output note's state blob no longer embeds the script, which is stored once in `notes_scripts` and joined back in on read. All tables are now `STRICT`, and the `tags` table stores its rows keyed by a `(tag, source)` primary key (`WITHOUT ROWID`) instead of carrying a separate unique index. This changes the schema fingerprint, so opening a database created before this change fails with `SchemaHashMismatch` and existing stores must be recreated.
+* [BREAKING][removal][test] Loose helper functions in `miden_client::testing::common` are now methods on `TestClient`. `TestClient::keystore()` exposes the client's keystore, so `ClientConfig::into_client` and `into_unsynced_client` return just the `TestClient` instead of a client/keystore pair ([#2477](https://github.com/0xMiden/rust-sdk/issues/2477)).


I think we should include the PR link here

Indeed, done in f4cb0fb

ricomateo · 2026-09-04T20:45:13Z

 ### Fixes

-* [FIX][test] The integration tests now run against a fee-charging chain. The testing node's genesis charges a fee by default (`MIDEN_VERIFICATION_BASE_FEE`, default `500`), generates the native fee faucet itself so the accounts it deploys can be seeded with that asset, and pre-funds a pool of basic wallets the suite draws from via a new `--funders` argument (`MIDEN_FUNDER_ACCOUNTS_DIR`). Accounts created by the `miden_client::testing::common` helpers are funded and deployed automatically, and `miden_client::testing::fee::deploy_account` does the same for accounts a test builds itself. The AggLayer accounts are consequently always part of genesis (the `AGGLAYER_GENESIS` env var and the `start-node-agglayer` target are gone) and the AggLayer tests load them from `AGGLAYER_ACCOUNTS_DIR` ([#2446](https://github.com/0xMiden/rust-sdk/issues/2446)).
+* [FIX][test] The integration tests now run against a fee-charging chain. The testing node's genesis charges a fee by default (`MIDEN_VERIFICATION_BASE_FEE`, default `500`), generates the native fee faucet itself so the accounts it deploys can be seeded with that asset, and pre-funds a pool of basic wallets the suite draws from via a new `--funders` argument (`MIDEN_FUNDER_ACCOUNTS_DIR`). A path naming no `.mac` file leaves the run without funders, which is all a fee-free genesis needs, since it declares no wallets for the path to hold. Accounts created by the `miden_client::testing::common` helpers are funded and deployed automatically, and `miden_client::testing::fee::deploy_account` does the same for accounts a test builds itself. The AggLayer accounts are consequently always part of genesis (the `AGGLAYER_GENESIS` env var and the `start-node-agglayer` target are gone) and the AggLayer tests load them from `AGGLAYER_ACCOUNTS_DIR` ([#2446](https://github.com/0xMiden/rust-sdk/issues/2446)).


nit: should this change be included in a separate entry instead of modifying the existing one?

Splitted in two in f4cb0fb

sofiazcoaga · 2026-09-09T13:03:41Z

+    pub async fn into_unsynced_client(self) -> Result<TestClient> {
        let fee_funder = self.fee_funder.clone();
-        let (builder, keystore) = self.into_client_builder()?;
+        let (builder, _keystore) = self.into_client_builder()?;


Do you think we could make into_client_builder() drop the keystore return entirely? It seems it is no longer being used anywhere since now TestClient::keystore() handles it. Same with create_test_client_builder()

Good suggestion, removed the keystore from the return values in ad8c0e8

sofiazcoaga · 2026-09-09T13:13:48Z

-    // callback slots on the faucet, which forces `FungibleAsset` keys to carry
-    // `AssetCallbackFlag::Enabled`. Tests construct assets via `FungibleAsset::new`, which defaults
-    // to `Disabled`, so adding transfer policies makes `mint_and_send` reject the mint with
-    // `ERR_FUNGIBLE_MINT_NOTE_ASSET_NOT_FROM_THIS_FAUCET`.


I think this deleted comment is still being referenced by tests.rs:4953 : "for the reason described in test_utils/common.rs"

Restored in ad8c0e8

juan518munoz added 2 commits September 2, 2026 12:46

test: refactor code to leverage TestClient

12973d0

test: make faucet funders loading not mandatory

0b09cdf

juan518munoz force-pushed the jmunoz-testClient-simplifications branch from 6631565 to 0b09cdf Compare September 2, 2026 15:46

juan518munoz marked this pull request as ready for review September 2, 2026 15:47

juan518munoz requested review from TomasArrachea, igamigo, ricomateo and sofiazcoaga September 2, 2026 15:47

Merge branch 'next' into jmunoz-testClient-simplifications

011b03f

ricomateo approved these changes Sep 4, 2026

View reviewed changes

juan518munoz added 5 commits September 7, 2026 16:01

chore: address PR comments

f4cb0fb

Merge branch 'next' into jmunoz-testClient-simplifications

b5abc76

Merge branch 'next' into jmunoz-testClient-simplifications

bf5a12e

fix: compilation after next merge

08b163c

Merge branch 'next' into jmunoz-testClient-simplifications

16f2f19

sofiazcoaga reviewed Sep 9, 2026

View reviewed changes

sofiazcoaga approved these changes Sep 9, 2026

View reviewed changes

juan518munoz added 3 commits September 9, 2026 14:22

chore: address PR comments

ad8c0e8

Merge branch 'next' into jmunoz-testClient-simplifications

0b14fb5

chore: fix linting

571d052

Navigation Menu

Uh oh!

Test: code simplifications - #2481

Test: code simplifications#2481
juan518munoz wants to merge 11 commits into
nextfrom
jmunoz-testClient-simplifications

juan518munoz commented Sep 2, 2026

Uh oh!

ricomateo Sep 4, 2026

Uh oh!

juan518munoz Sep 7, 2026

Uh oh!

ricomateo Sep 4, 2026

Uh oh!

juan518munoz Sep 7, 2026

Uh oh!

ricomateo Sep 4, 2026

Uh oh!

juan518munoz Sep 7, 2026

Uh oh!

sofiazcoaga Sep 9, 2026

Uh oh!

juan518munoz Sep 9, 2026

Uh oh!

sofiazcoaga Sep 9, 2026 •

edited

Loading

Uh oh!

juan518munoz Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

juan518munoz commented Sep 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sofiazcoaga Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sofiazcoaga Sep 9, 2026 •

edited

Loading