chore: address followup comments for node update & re-export NetworkNotePricer - #2475
chore: address followup comments for node update & re-export NetworkNotePricer#2475juan518munoz wants to merge 7 commits into
NetworkNotePricer#2475Conversation
19dfecf to
7910877
Compare
0.16 updateNetworkNotePricer
igamigo
left a comment
There was a problem hiding this comment.
Looks good, but I think there might be a regression here. In any case I think this warrants a bigger refactor (#2118) so maybe we fix the issue, merge this anyway and improve the whole setup afterward. I believe there are a couple of structs we could get rid of.
There was a problem hiding this comment.
There does not seem to be any entry here for PR 2475
| // The screener and the note tracker work on the sync record alone, with attachments | ||
| // supplied separately, so hand them the record without its resolved content. | ||
| let committed = CommittedNote::new(note_id, metadata, inclusion_proof); |
There was a problem hiding this comment.
I think this effectively removes the attachments which means the user does not have that information during the callback
There was a problem hiding this comment.
The screener's record is now built with SyncedNote::to_committed_note() instead of CommittedNote::new(), so it carries the resolved attachments (an empty set for a note without any) rather than None.
Closes #2473
CHANGELOGfix: The five entries that pointed at issue Updatenodeto 0.16 #2360/chore: update node to0.16#2431 now cite PR chore: update node to0.16#2431. TheGetAccountbehavior entry was dropped per your earlier decision.SyncedNoteto observer:NoteObserver::observenow takes&SyncedNote.SyncedNote: flattened tonote_id,metadata,inclusion_proof,details,attachments.ReportedAttachmentenum andReportedAttachments::from_reports.ResolvedNoteContent: superseded by the flatten of point 3.scripts/start-test-node.shwas replaced by three hardcoded insecure test-only keys.Closes #2517
NetworkNotePricer