fix(standards): use the signed block for multisig fee-note serials - #3839
Merged
Conversation
partylikeits1983
marked this pull request as ready for review
September 9, 2026 14:58
partylikeits1983
requested review from
bobbinth,
igamigo and
mmagician
and removed request for
bobbinth
September 9, 2026 14:58
partylikeits1983
added
fees
mmagician
approved these changes
Sep 9, 2026
mmagician
left a comment
mmagician
left a comment
Collaborator
There was a problem hiding this comment.
Overall the approach LGTM, though docs and tests can be cut down and cleared up a bit ✅
bobbinth
approved these changes
Sep 9, 2026
bobbinth
left a comment
bobbinth
left a comment
Contributor
There was a problem hiding this comment.
I mostly reviewed the non-test code - but looks good! Thank you!
igamigo
approved these changes
Sep 9, 2026
igamigo
left a comment
igamigo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I don't fully understand what the idea behind making the block number be part of the serial number is (I think I recall glossing over some comment in one of the fee PRs), but while that is a thing, these changes look correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets multisig approvals remain valid when a transaction executes against a newer block. Previously, changing the execution block changed the fee note’s serial number and invalidated signatures, even when the fee and transaction effects stayed the same.
The fee note’s serial now uses the signed proposal block. The shared fee helpers accept that block explicitly. Signature reuse still requires an unchanged nonce, fee, and signed effects, and an unexpired approval.
Once integrated into Guardian and the client, this will allow multisig transactions to execute using current account state instead of requiring historical account state throughout signature collection.
Caveat: Clients still need the proposal block’s commitment and a proof of its inclusion in the chain. cc @igamigo
Fixes #3836.