docs(0.14): document native asset vault key/value encoding - #371
Open
kutluhaneth46 wants to merge 2 commits into
Open
docs(0.14): document native asset vault key/value encoding#371kutluhaneth46 wants to merge 2 commits into
kutluhaneth46 wants to merge 2 commits into
Conversation
Add the ASSET_KEY / ASSET_VALUE layout for fungible and non-fungible assets, including the callback flag in faucet_id_suffix, and align the create_non_fungible_asset Inputs row with enable_callbacks.
BrianSeong99
reviewed
Sep 8, 2026
BrianSeong99
left a comment
BrianSeong99
left a comment
Contributor
There was a problem hiding this comment.
One correctness issue before approval.
|
|
||
| | Kind | Value word | | ||
| | --- | --- | | ||
| | Fungible | `[amount, 0, 0, 0]` — `amount ≤ 2⁶³−1` | |
Contributor
There was a problem hiding this comment.
P1: The maximum fungible amount in v0.14.6 is 2⁶³−2³¹, not 2⁶³−1. Could we update this row so it matches FungibleAsset::MAX_AMOUNT and FUNGIBLE_ASSET_MAX_AMOUNT?
Author
There was a problem hiding this comment.
Good catch — updated both places (the vault ASSET_VALUE table row and the earlier fungible-asset prose) to 2⁶³−2³¹, matching FungibleAsset::MAX_AMOUNT / FUNGIBLE_ASSET_MAX_AMOUNT (0x7fffffff80000000).
Align the vault encoding table and fungible asset prose with FungibleAsset::MAX_AMOUNT / FUNGIBLE_ASSET_MAX_AMOUNT (0x7fffffff80000000).
Author
|
Addressed @BrianSeong99's P1: fungible max amount is now documented as `2⁶³−2³¹` (not `2⁶³−1`) in both the prose and the `ASSET_VALUE` table, matching `FungibleAsset::MAX_AMOUNT` / `FUNGIBLE_ASSET_MAX_AMOUNT`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASSET_KEY/ASSET_VALUElayout (fungible vs non-fungible, callback flag infaucet_id_suffix) underversioned_docs/version-0.14/reference/protocol/asset.md#encoding.create_non_fungible_assetInputs with the fungible helper (enable_callbacksfirst) inprotocol_library.md.#encoding.Test plan
AssetVaultKey::to_word()on the v0.14.6 tag