This repository was archived by the owner on Aug 7, 2026. It is now read-only.
fix(falcon): add missing return in Polynomial::div for zero numerator - #1106
Open
Sertug17 wants to merge 1 commit into
Open
fix(falcon): add missing return in Polynomial::div for zero numerator#1106Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
Author
|
/quality-review The automated check flagged this as trivial. I'll add a regression test for zero numerator division. Pushing shortly. |
Sertug17
force-pushed
the
fix/polynomial-div-missing-return
branch
from
July 31, 2026 19:27
8a8578b to
8c8fe3c
Compare
Polynomial::div discards the result of Self::zero() when the numerator is zero because the return keyword is missing. Execution falls through to the division loop where remainder.degree().unwrap() panics on None. Fixes #1105
Sertug17
force-pushed
the
fix/polynomial-div-missing-return
branch
from
July 31, 2026 19:29
8c8fe3c to
104d4a6
Compare
Author
|
/quality-review Added a regression test ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 0xMiden/miden-vm#3534
Polynomial::divdiscards the result ofSelf::zero()when the numerator is zero because thereturnkeyword is missing. Execution falls through to the division loop whereremainder.degree().unwrap()panics onNone.Fix
Testing
Dividing a zero polynomial by a non-zero polynomial now returns zero instead of panicking.