Skip to content
This repository was archived by the owner on Aug 7, 2026. It is now read-only.

fix(bench): validate trace spec dimensions - #1080

Open
blackflytech wants to merge 1 commit into
0xMiden:nextfrom
blackflytech:next
Open

fix(bench): validate trace spec dimensions#1080
blackflytech wants to merge 1 commit into
0xMiden:nextfrom
blackflytech:next

Conversation

@blackflytech

Copy link
Copy Markdown

Describe your changes

This PR tightens miden-bench trace spec parsing so that invalid or misleading trace specifications are rejected early.

Specifically, it:

  • rejects trace specs with more fields than AIR:LOG_HEIGHT[:WIDTH[:AUX_COLS]];
  • rejects WIDTH / AUX_COLS for non-Miden traces, since those dimensions only apply to miden;
  • keeps the existing Miden defaults for omitted dimensions;
  • adds unit coverage for valid Miden specs, valid hash specs, and invalid extra dimensions.

This avoids accepting CLI input where extra fields appear meaningful but are ignored by the benchmark runner.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@github-actions

Copy link
Copy Markdown

Automated check (CONTRIBUTING.md)

Findings:

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

Signed-off-by: blackflytech <blackflytech@outlook.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant