feat: add predicate relationship metadata#5
Draft
jonathanprozzi wants to merge 4 commits into
Draft
Conversation
95dafee to
8101682
Compare
00fa2dd to
83f0d65
Compare
8101682 to
ace5ba1
Compare
83f0d65 to
5a42a41
Compare
Member
Author
|
Disposition note: this PR should stay draft / review-only and should not be merged as-is. The relationship metadata shape explored here has been superseded by the classification-owned metadata predicate matrix in PR #7. That matrix moves subject/object relationship contracts out of predicate specs and keys them by Useful review value from this PR: it helped identify the contract requirements. Merge path: #3 -> #4 -> #6 -> #7 -> #8, with this PR excluded unless we intentionally revive a narrowed piece later. |
86358a2 to
b1b4e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Superseded by the classification-owned matrix approach in #7. This draft remains open only as historical review context for the predicate-level relationship experiment.
What This Experiment Tried
Why It Should Not Merge As-Is
This shape puts classification-specific relationship metadata inside
@0xintuition/predicates, which creates the coupling we want to avoid. It also mixes identifier namespaces inexpectedObjectTypesand duplicates the subject/predicate relationship data that classifications now own throughmetadataPredicates.The replacement direction is #7:
@0xintuition/predicatesdefines reusable predicate vocabulary.@0xintuition/classificationsowns the matrix keyed by(subjectClassification, predicate).Stack
This branch is stacked on
feat/predicate-metadata-backfill, but it should stay draft and out of the merge path unless we intentionally revive part of the experiment.