Skip to content

Default Product Group Attribute #916

Description

@BigRoy

Story

Before attributes were a thing we've always had productGroup data on products to visualize custom user grouping in the desktop tools. However, now with Group By features over custom attributes we're thinking of moving this over to be a dedicated custom attribute.

It'd be an attribute that exists by default, but is not required. However, desktop tools would try to use it if it does exist.

Problems

  • Remove the need for the legacy productGroup data on products that is only visualized and used in desktop tools
  • Enforce data consistency for the type itself

Proposal

  • Add a default string attribute productGroup that is scoped to just Product.
  • Add migration that takes any product.data.productGroup and transfers it to product.attrs.productGroup

TODO

  • Add a default string attribute productGroup that is scoped to just Product.
  • Add migration that takes any product.data.productGroup and transfers it to product.attrs.productGroup
  • Ensure the desktop tools and core code also starts relying on attributes equivalent instead of the key in data.

Attachments

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: enhancementImprovement of existing functionality or minor addition

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions