From cdbe975fe8a95bbce8dafd6715a94b25ac69f050 Mon Sep 17 00:00:00 2001 From: Sid Date: Fri, 26 Jun 2026 20:13:06 +0530 Subject: [PATCH 1/2] ci: use env vars instead of hard coded paths --- .../oauth1/linux/setup-feature-specific-deps/action.yml | 7 +++++-- .../ssl/linux/setup-feature-specific-deps/action.yml | 7 +++++-- .github/workflows/benchmarks.yml | 7 +++++-- .github/workflows/flaky-test-detector.yml | 7 +++++-- .github/workflows/tests-linux.yml | 7 +++++-- 5 files changed, 25 insertions(+), 10 deletions(-) diff --git a/.github/actions/auth/oauth1/linux/setup-feature-specific-deps/action.yml b/.github/actions/auth/oauth1/linux/setup-feature-specific-deps/action.yml index 157c371ea38..ff60c162c3c 100644 --- a/.github/actions/auth/oauth1/linux/setup-feature-specific-deps/action.yml +++ b/.github/actions/auth/oauth1/linux/setup-feature-specific-deps/action.yml @@ -11,5 +11,8 @@ runs: libglib2.0-0 libnss3 libdbus-1-3 libatk1.0-0 libatk-bridge2.0-0 libcups2 libgtk-3-0 libasound2t64 \ xvfb - sudo chown root /home/runner/work/bruno/bruno/node_modules/electron/dist/chrome-sandbox - sudo chmod 4755 /home/runner/work/bruno/bruno/node_modules/electron/dist/chrome-sandbox + CHROME_SANDBOX="${GITHUB_WORKSPACE}/node_modules/electron/dist/chrome-sandbox" + if [[ -f "$CHROME_SANDBOX" ]]; then + sudo chown root "$CHROME_SANDBOX" + sudo chmod 4755 "$CHROME_SANDBOX" + fi diff --git a/.github/actions/ssl/linux/setup-feature-specific-deps/action.yml b/.github/actions/ssl/linux/setup-feature-specific-deps/action.yml index 475dac0a528..e8aa7f33829 100644 --- a/.github/actions/ssl/linux/setup-feature-specific-deps/action.yml +++ b/.github/actions/ssl/linux/setup-feature-specific-deps/action.yml @@ -11,5 +11,8 @@ runs: libglib2.0-0 libnss3 libdbus-1-3 libatk1.0-0 libatk-bridge2.0-0 libcups2 libgtk-3-0 libasound2t64 \ xvfb libxml2-utils - sudo chown root /home/runner/work/bruno/bruno/node_modules/electron/dist/chrome-sandbox - sudo chmod 4755 /home/runner/work/bruno/bruno/node_modules/electron/dist/chrome-sandbox + CHROME_SANDBOX="${GITHUB_WORKSPACE}/node_modules/electron/dist/chrome-sandbox" + if [[ -f "$CHROME_SANDBOX" ]]; then + sudo chown root "$CHROME_SANDBOX" + sudo chmod 4755 "$CHROME_SANDBOX" + fi diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 304af458483..acc428c3064 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -45,8 +45,11 @@ jobs: - name: Configure Chrome Sandbox if: matrix.os-name == 'ubuntu' run: | - sudo chown root node_modules/electron/dist/chrome-sandbox - sudo chmod 4755 node_modules/electron/dist/chrome-sandbox + CHROME_SANDBOX="${GITHUB_WORKSPACE}/node_modules/electron/dist/chrome-sandbox" + if [[ -f "$CHROME_SANDBOX" ]]; then + sudo chown root "$CHROME_SANDBOX" + sudo chmod 4755 "$CHROME_SANDBOX" + fi - name: Run Benchmark Tests uses: ./.github/actions/tests/run-benchmark-tests diff --git a/.github/workflows/flaky-test-detector.yml b/.github/workflows/flaky-test-detector.yml index f78b3fc4477..1421ae54be2 100644 --- a/.github/workflows/flaky-test-detector.yml +++ b/.github/workflows/flaky-test-detector.yml @@ -40,8 +40,11 @@ jobs: - name: Install npm dependencies run: | npm ci --legacy-peer-deps - sudo chown root /home/runner/work/bruno/bruno/node_modules/electron/dist/chrome-sandbox - sudo chmod 4755 /home/runner/work/bruno/bruno/node_modules/electron/dist/chrome-sandbox + CHROME_SANDBOX="${GITHUB_WORKSPACE}/node_modules/electron/dist/chrome-sandbox" + if [[ -f "$CHROME_SANDBOX" ]]; then + sudo chown root "$CHROME_SANDBOX" + sudo chmod 4755 "$CHROME_SANDBOX" + fi - name: Install test collection dependencies run: npm ci --prefix packages/bruno-tests/collection diff --git a/.github/workflows/tests-linux.yml b/.github/workflows/tests-linux.yml index 350f892f91a..028f424423c 100644 --- a/.github/workflows/tests-linux.yml +++ b/.github/workflows/tests-linux.yml @@ -71,8 +71,11 @@ jobs: - name: Configure Chrome Sandbox run: | - sudo chown root node_modules/electron/dist/chrome-sandbox - sudo chmod 4755 node_modules/electron/dist/chrome-sandbox + CHROME_SANDBOX="${GITHUB_WORKSPACE}/node_modules/electron/dist/chrome-sandbox" + if [[ -f "$CHROME_SANDBOX" ]]; then + sudo chown root "$CHROME_SANDBOX" + sudo chmod 4755 "$CHROME_SANDBOX" + fi - name: Run E2E Tests uses: ./.github/actions/tests/run-e2e-tests From 449372d54771a0bd836ab98a574ea41abb660eb9 Mon Sep 17 00:00:00 2001 From: Sid Date: Fri, 26 Jun 2026 20:14:04 +0530 Subject: [PATCH 2/2] ci: for large runner --- .github/workflows/tests-linux.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux.yml b/.github/workflows/tests-linux.yml index 028f424423c..038f4bf4735 100644 --- a/.github/workflows/tests-linux.yml +++ b/.github/workflows/tests-linux.yml @@ -54,7 +54,10 @@ jobs: e2e-test: name: Playwright E2E Tests (Linux) timeout-minutes: 240 - runs-on: ubuntu-24.04 + runs-on: + - ubuntu-24.04 + - self-hosted + - large-runner steps: - uses: actions/checkout@v6