From 9d6deb704dbf3075dd6db2ab0e16a08308009d87 Mon Sep 17 00:00:00 2001 From: Terence Honles Date: Wed, 25 Apr 2018 13:59:42 -0700 Subject: [PATCH] fix invalid return type causing `set() | None` This code seems like it should be exhausting the iterator rather than returning early --- pootle/apps/accounts/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pootle/apps/accounts/utils.py b/pootle/apps/accounts/utils.py index c87326ac3af..5ab763b6b03 100644 --- a/pootle/apps/accounts/utils.py +++ b/pootle/apps/accounts/utils.py @@ -362,7 +362,7 @@ def revert_units_state_changed(self): # If the unit has been changed more recently we don't need to # revert the unit state. submission.delete() - return + continue submission.delete() other_submissions = (unit.get_state_changes() .exclude(submitter=self.user))