Use compatible Windows paths in output

Author: smoelius

Cargo.lock

@@ -25,6 +25,7 @@ dylint_internal = { version = "=6.3.2", path = "../internal" }
 assert_cmd = { workspace = true }
 cargo_metadata = { workspace = true }
 ctor = { workspace = true }
+dunce = { workspace = true }
 glob = { workspace = true }
 ignore = { workspace = true }
 log = { workspace = true }

cargo-dylint/Cargo.toml

@@ -427,7 +427,7 @@ fn markdown_does_not_use_inline_links() {
         assert!(
             !re.is_match(&markdown),
             "`{}` uses inline links",
-            path.canonicalize().unwrap().to_string_lossy()
+            dunce::canonicalize(path).unwrap().to_string_lossy()
         );
     }
 }
@@ -451,7 +451,7 @@ fn markdown_reference_links_are_sorted() {
         assert!(
             links_sorted == links,
             "contents of `{}` are not what was expected:\n{}\n",
-            path.canonicalize().unwrap().to_string_lossy(),
+            dunce::canonicalize(path).unwrap().to_string_lossy(),
             links_sorted.join("\n")
         );
     }

cargo-dylint/tests/ci.rs

@@ -258,7 +258,5 @@ fn list_by_path() {
 fn target_debug(dir: &Path) -> Result<PathBuf> {
     let metadata = dylint_internal::cargo::metadata(dir)?;
     let debug_dir = metadata.target_directory.join("debug");
-    debug_dir
-        .canonicalize()
-        .with_context(|| format!("Could not canonicalize {debug_dir:?}"))
+    dunce::canonicalize(&debug_dir).with_context(|| format!("Could not canonicalize `{debug_dir}`"))
 }

cargo-dylint/tests/integration/list.rs

@@ -16,7 +16,7 @@ cargo-util = { workspace = true, optional = true }
 cargo-util-schemas = { workspace = true, optional = true }
 cargo_metadata = { workspace = true }
 chrono = { workspace = true, optional = true }
-dunce = { workspace = true, optional = true }
+dunce = { workspace = true }
 fs_extra = { workspace = true, optional = true }
 glob = { workspace = true, optional = true }
 heck = { workspace = true, optional = true }
@@ -83,7 +83,6 @@ package_options = [
 __cargo_cli = [
     "cargo-util",
     "cargo-util-schemas",
-    "dunce",
     "dylint_internal/home",
     "fs_extra",
     "glob",

dylint/Cargo.toml

@@ -300,7 +300,7 @@ where
 }
 
 fn name_as_path(name: &str, as_path_only: bool) -> Result<Option<(String, PathBuf)>> {
-    if let Ok(path) = PathBuf::from(name).canonicalize() {
+    if let Ok(path) = dunce::canonicalize(name) {
         if let Some((_, toolchain)) = parse_path_with_toolchain(&path) {
             return Ok(Some((toolchain, path)));
         }
@@ -482,17 +482,19 @@ fn list_lints(opts: &opts::Dylint, resolved: &ToolchainMap) -> Result<()> {
 
 fn display_location(path: &Path) -> Result<String> {
     let current_dir = current_dir().with_context(|| "Could not get current directory")?;
+    let current_dir_canonicalized = current_dir
+        .canonicalize()
+        .with_context(|| format!("Could not canonicalize `{}`", current_dir.display()))?;
     let Ok(path_buf) = path.canonicalize() else {
         return Ok("<unbuilt>".to_owned());
     };
     let parent = path_buf
         .parent()
         .ok_or_else(|| anyhow!("Could not get parent directory"))?;
-    Ok(parent
-        .strip_prefix(&current_dir)
-        .unwrap_or(parent)
-        .to_string_lossy()
-        .to_string())
+    let location = parent
+        .strip_prefix(&current_dir_canonicalized)
+        .unwrap_or(parent);
+    Ok(dunce::simplified(location).to_string_lossy().to_string())
 }
 
 fn clippy_disable_docs_links() -> Result<String> {