Repository navigation
Commit 934fdad
Thales
fix(player): stop logging six audio errors on every engine-backed load
Every track that plays through the Web Audio engine logged one
MEDIA_ELEMENT_ERROR "Empty src attribute" per stem, six lines, before the
user had done anything.
The elements really do have no source, and that is correct: when the engine
owns playback the multitrack is built with url: null for every stem, because
the engine streams the audio itself and the multitrack is only there for the
lanes. The guard that was supposed to skip those tested
stemsByName[name].url instead, which is the original descriptor and still
holds the real URL. So it passed, attached an error listener to an element
that was deliberately never given a src, and the element duly reported one.
Adds useEngine to the test, mirroring the condition that nulls the URLs in
the first place.
Playback was never affected. The cost was that anyone reading a console, or
attaching one to a bug report, saw six errors that had nothing to do with
their problem. It showed up while verifying #600 and is unrelated to it.1 parent 69c434b commit 934fdad
1 file changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1320 | 1320 | | |
1321 | 1321 | | |
1322 | 1322 | | |
1323 | | - | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
1324 | 1333 | | |
1325 | | - | |
| 1334 | + | |
1326 | 1335 | | |
1327 | 1336 | | |
1328 | 1337 | | |
| |||
0 commit comments