Fetch all withdrawal assets for token select - #27
alan-provable wants to merge 1 commit into
Conversation
|
@alan-provable is attempting to deploy a commit to the rosen-bridge Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Quick check note: the failing Vercel statuses I can see are asking a rosen-bridge team member to authorize preview deployments for this fork. The local validation I could run passed ( |
6968c72 to
11f5334
Compare
|
|
||
| const WITHDRAW_ASSETS_PAGE_SIZE = 100; | ||
|
|
||
| const fetchAddressAssets = async (): Promise<ApiAddressAssetsResponse> => { |
There was a problem hiding this comment.
Reduce Redundant API Path by Passing the URL as an Argument
const fetchAddressAssets = async (url: string): Promise<ApiAddressAssetsResponse> =>
|
Please update your branch with the latest changes from |
2 participants
Closes #10.
What changed
/address/assetswithoffsetandlimituntil it has collected the API-reportedtotal.Why
The withdrawal token select only used the default
/address/assetsresponse. When an address had more tokens than the default page size, later tokens never appeared in the select.Validation
git diff --checkI also tried
npm ci --ignore-scripts --no-audit --no-fund, but this checkout cannot install cleanly as-is in my environment because the package lock is out of sync and my local Node/npm versions are below the repo engine requirement.