Skip to content

Fix for #243 (deprecations in GObject) - #244

Open
oss-vineet wants to merge 1 commit into
ros-drivers:masterfrom
oss-vineet:master
Open

Fix for #243 (deprecations in GObject)#244
oss-vineet wants to merge 1 commit into
ros-drivers:masterfrom
oss-vineet:master

Conversation

@oss-vineet

@oss-vineet oss-vineet commented Nov 24, 2023

Copy link
Copy Markdown

GObject replaced by Glib due to deprecation (#243)

@oss-vineet oss-vineet changed the title Fix for #243 Fix for #243 (deprecations in GObject) Nov 26, 2023
@tomkimsour

Copy link
Copy Markdown
Contributor

This is resolving

[soundplay_node.py-1] /opt/ros/humble/lib/sound_play/soundplay_node.py:215: PyGIDeprecationWarning: Since version 3.11, calling threads_init is no longer needed. See: https://wiki.gnome.org/PyGObject/Threading
[soundplay_node.py-1]   GObject.threads_init()
[soundplay_node.py-1] /opt/ros/humble/lib/sound_play/soundplay_node.py:216: PyGIDeprecationWarning: GObject.MainLoop is deprecated; use GLib.MainLoop instead

@tomkimsour

Copy link
Copy Markdown
Contributor

@knorth55 Could you check this please ?

@knorth55

knorth55 commented Aug 5, 2026

Copy link
Copy Markdown
Member

@tomkimsour
this PR is targeted to master branch (ROS1 branch), so I will not merge this PR.
if you want to remove the deprecation warning, you can open a similar PR to ROS2 branch.

This PR just remove warning and does not implement new feature nor fix a bug, so I'm not super open to merge this.
This kind of PR is correct, but, at the same time, it may drop backward compatibility.

But if you think the warning message is too annoying, I can merge the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants