Fix hosted deployment verification

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>

Author: jeremi

README.md

@@ -201,8 +201,8 @@ candidate-only gate locally with `just review-release <registry-stack-tag>`;
 the normal contributor and CI gate remains `just review`.
 
 For local eSignet testing, run `just up-esignet` instead of `just up`, then
-sign in through the portal with Elena's fixture `legacy_nid` and static OTP
-`111111`. This sign-in is the end-to-end check of the NIA
+sign in through the portal with Elena's fixture UIN `2300018263` and static
+OTP `111111`. This sign-in is the end-to-end check of the NIA
 `solmara-nia-userinfo` attribute-release profile and its rotating eSignet
 workload identity. Run `just smoke-esignet` for the public discovery checks.
 

home/e2e/home.test.ts

@@ -2,6 +2,9 @@ import { expect, test } from '@playwright/test';
 
 const NAV_LINKS = ['Stories', 'Explorer', 'Purposes', 'Problem codes', 'Anatomy', 'Status'];
 
+const evaluationUrl = (configuredUrl: string | undefined, fallbackUrl: string) =>
+  `${(configuredUrl ?? fallbackUrl).replace(/\/+$/, '')}/v1/evaluations`;
+
 test('landing renders with header nav and every section in order', async ({ page }) => {
   const response = await page.goto('/');
   expect(response?.headers()['content-security-policy']).toContain("default-src 'self'");
@@ -195,8 +198,12 @@ test('citizen story renders runnable curls for each authority call', async ({ pa
   const authorityRequests = result.locator('.request-list .peer-call');
   await expect(authorityRequests).toHaveCount(2);
   await expect(authorityRequests.getByRole('button', { name: 'Copy as curl' })).toHaveCount(2);
-  await expect(authorityRequests.nth(0)).toContainText('http://localhost:4325/v1/evaluations');
-  await expect(authorityRequests.nth(1)).toContainText('http://localhost:4326/v1/evaluations');
+  await expect(authorityRequests.nth(0)).toContainText(
+    evaluationUrl(process.env.CRA_NOTARY_URL, 'http://localhost:4325')
+  );
+  await expect(authorityRequests.nth(1)).toContainText(
+    evaluationUrl(process.env.NIA_NOTARY_URL, 'http://localhost:4326')
+  );
   await expect(result).not.toContainText('solmara://authority-notaries');
 });
 

scripts/smoke-hosted.py

@@ -90,16 +90,7 @@ def main(argv: list[str] | None = None) -> int:
         (
             "eSignet backend",
             lambda: run_command(
-                [
-                    sys.executable,
-                    str(ROOT / "scripts" / "smoke-esignet.py"),
-                    "--relay-url",
-                    relay_url(targets, "SOLMARA_NIA_RELAY_URL"),
-                    "--esignet-url",
-                    targets.esignet_url,
-                    "--esignet-ui-url",
-                    targets.esignet_ui_url,
-                ],
+                esignet_smoke_command(targets),
                 env,
                 cwd=ROOT,
             ),
@@ -184,6 +175,17 @@ def main(argv: list[str] | None = None) -> int:
     return 0
 
 
+def esignet_smoke_command(targets: HostedTargets) -> list[str]:
+    return [
+        sys.executable,
+        str(ROOT / "scripts" / "smoke-esignet.py"),
+        "--esignet-url",
+        targets.esignet_url,
+        "--esignet-ui-url",
+        targets.esignet_ui_url,
+    ]
+
+
 def parse_args(argv: list[str] | None) -> argparse.Namespace:
     parser = argparse.ArgumentParser(description=__doc__)
     parser.add_argument(
@@ -343,13 +345,6 @@ def hosted_env(
     return env
 
 
-def relay_url(targets: HostedTargets, env_name: str) -> str:
-    for relay in targets.relays:
-        if relay.env_name == env_name:
-            return relay.base_url
-    raise SmokeFailure(f"missing relay target for {env_name}")
-
-
 def check_public_routes(targets: HostedTargets, timeout: float) -> None:
     checks = [
         ServiceTarget("Visitor Center", targets.home_url, "/"),

scripts/test_smoke_hosted.py

@@ -238,6 +238,22 @@ def test_normalize_argv_accepts_just_separator(self) -> None:
         )
         self.assertEqual(smoke_hosted.normalize_argv(["--browser"]), ["--browser"])
 
+    def test_esignet_smoke_uses_only_supported_discovery_arguments(self) -> None:
+        targets = smoke_hosted.default_targets("solmara.registrystack.org")
+
+        command = smoke_hosted.esignet_smoke_command(targets)
+
+        self.assertNotIn("--relay-url", command)
+        self.assertEqual(
+            command[-4:],
+            [
+                "--esignet-url",
+                "https://esignet.solmara.registrystack.org",
+                "--esignet-ui-url",
+                "https://esignet-ui.solmara.registrystack.org",
+            ],
+        )
+
     def test_home_demo_accepts_expected_scenario_flow(self) -> None:
         with StubServer(hosted_routes()) as server:
             smoke_hosted.check_home_demo(server.url, timeout=2)