Repository navigation
Commit 953362a
On CPython 3.10.0, NodeId's cached-string attribute isn't initialized because of python/cpython#88815. Calling str() on it raises AttributeError and prevents pytest from starting.
This reads the cache with getattr and a None default, then lets the existing code rebuild it. Added a regression test that simulates the missing attribute, plus a changelog entry.
The relevant suites pass on Python 3.10.0 and 3.14. The regression test fails without the fix on 3.14, and a trivial suite that previously crashed now runs on 3.10.0.
AI assistance: this fix, regression test and PR description were prepared with Instinct.
Fixes #15337.
(cherry picked from commit 50234b4)
Co-authored-by: Aathithya Arasu S <142731071+Aathi-27@users.noreply.github.com>
1 parent c5a4d14 commit 953362a
4 files changed
Lines changed: 28 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
62 | 68 | | |
63 | 69 | | |
64 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
26 | 44 | | |
27 | 45 | | |
28 | 46 | | |
| |||
0 commit comments