From 781e034647c6d1054dc3273851d41bc488d20dea Mon Sep 17 00:00:00 2001 From: Jason Date: Wed, 19 Mar 2025 02:26:54 +0000 Subject: [PATCH 1/2] Fix tests with new error text --- packages/pug/test/error.reporting.test.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/pug/test/error.reporting.test.js b/packages/pug/test/error.reporting.test.js index 99ee8e3a4..1815fa6f4 100644 --- a/packages/pug/test/error.reporting.test.js +++ b/packages/pug/test/error.reporting.test.js @@ -209,7 +209,9 @@ describe('error reporting', function() { {} ); expect(err.message).toMatch(/mixin.error.pug:2/); - expect(err.message).toMatch(/Cannot read property 'length' of null/); + expect(err.message).toMatch( + /Cannot read (property 'length' of null|properties of null)/ + ); }); }); describe('in a layout', function() { @@ -220,7 +222,7 @@ describe('error reporting', function() { ); expect(err.message).toMatch(/layout.with.runtime.error.pug:3/); expect(err.message).toMatch( - /Cannot read property 'length' of undefined/ + /Cannot read (property 'length' of undefined|properties of undefined)/ ); }); }); From 54ca50efa93c7a3b440604244072f58fe621fc4c Mon Sep 17 00:00:00 2001 From: Jason Date: Thu, 20 Mar 2025 17:05:55 +0000 Subject: [PATCH 2/2] Use latest node versions Node v14 was EoL 2 years ago --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4903918c2..c2c969897 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - node-version: [10.x, 12.x, 14.x] + node-version: [18.x, 20.x, 22.x, 23.x] steps: - uses: actions/checkout@v2