From d16d9838d036b92b0bebbed5b8a9079df2562e98 Mon Sep 17 00:00:00 2001
From: Michal Schmidt <mschmidt@redhat.com>
Date: Mon, 30 Mar 2026 08:56:18 +0200
Subject: [PATCH] gitlab: fix showing #unknown for MR/issue IDs

When a project has more than 20 pages of MRs or issues, the
bulk listing is skipped and lookups by global ID fail, causing
"unknown" to be displayed instead of the actual IID. Use
target_iid / noteable_iid fields directly from the GitLab
Events API response instead of the expensive bulk lookups.

Assisted-by: Claude:claude-opus-4-6
---
 did/plugins/gitlab.py | 42 +++---------------------------------------
 1 file changed, 3 insertions(+), 39 deletions(-)

diff --git a/did/plugins/gitlab.py b/did/plugins/gitlab.py
index 8ac6165b..027b9503 100644
--- a/did/plugins/gitlab.py
+++ b/did/plugins/gitlab.py
@@ -327,20 +327,11 @@ def __init__(self, data: dict, parent: "GitLabStats", set_id=None):
         self.data = data
         self.gitlabapi: GitLab = parent.gitlab
         self.project = self.gitlabapi.get_project(data['project_id'])
-        self.id = set_id
-        if set_id is None:
-            self.id = self.iid()
+        self.id = set_id if set_id is not None else data.get(
+            'target_iid', 'unknown')
         self.title = data['target_title']
         self._body: Optional[str] = None
 
-    def iid(self):
-        issue = self.gitlabapi.get_project_issue(
-            self.data['project_id'], self.data['target_id'])
-
-        if issue is not None:
-            return issue['iid']
-        return "unknown"
-
     @property
     def body(self) -> str:
         """Get full issue description (lazy-loaded)"""
@@ -395,14 +386,6 @@ def __str__(self):
 class MergeRequest(Issue):
     # pylint: disable=too-few-public-methods
 
-    def __init__(self, data, parent, set_id=None):
-        if set_id is None:
-            merge_request = parent.gitlab.get_project_mr(
-                data['project_id'], data['target_id'])
-            if merge_request is not None:
-                set_id = merge_request['iid']
-        super().__init__(data, parent, set_id)
-
     @property
     def body(self) -> str:
         """Get full MR description (lazy-loaded)"""
@@ -418,28 +401,9 @@ class Note(Issue):
 
     def __init__(self, data, parent, set_id=None):
         if set_id is None:
-            set_id = self.note_iid(data, parent.gitlab)
+            set_id = data['note'].get('noteable_iid', 'unknown')
         super().__init__(data, parent, set_id)
 
-    def note_iid(self, data, gitlabapi):
-        if data['note']['noteable_type'] == 'Issue':
-            issue = gitlabapi.get_project_issue(
-                data['project_id'],
-                data['note']['noteable_id'])
-
-            # `noteable_type` is `Issue` even for `WorkItem`s, which
-            # aren't returned by `get_project_issue()`
-            if issue is not None:
-                return issue['iid']
-            return 'unknown'
-        if data['note']['noteable_type'] == 'MergeRequest':
-            merge_request = gitlabapi.get_project_mr(
-                data['project_id'],
-                data['note']['noteable_id'])
-            if merge_request is not None:
-                return merge_request['iid']
-        return "unknown"
-
     @property
     def body(self) -> str:
         """Get full issue/MR description (lazy-loaded)"""