Implement unquoting and add support for .() and ..() - #1347
Merged
Conversation
lionel-
force-pushed
the
oak-nse/9-unquote
branch
2 times, most recently
from
July 17, 2026 11:26
96dff66 to
dacdce8
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 17, 2026 13:55
dacdce8 to
604935e
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 22, 2026 12:46
604935e to
fcd89cd
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 22, 2026 15:25
fcd89cd to
e2db6c2
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 28, 2026 12:27
e2db6c2 to
a995343
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 30, 2026 14:38
a995343 to
8b9c343
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 30, 2026 15:24
8b9c343 to
581747a
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 31, 2026 07:08
581747a to
a3d7d53
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 31, 2026 12:28
a3d7d53 to
5928781
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
2 times, most recently
from
August 3, 2026 13:16
ef86a89 to
66c3be6
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
August 3, 2026 13:17
66c3be6 to
9f5ab24
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
August 3, 2026 16:18
9f5ab24 to
73ef160
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
August 3, 2026 16:27
73ef160 to
5d887b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1338
Branched from #1346
ResolvedArgumentEffect::Quotenow carriesholes, the escaped sub-expressions. The builder walks each hole normally (uses, nested effects, goto/rename) and leaves the rest of the quoted expression inert.Since unquoting is a complex effect (especially for tidyeval where
!!has custom operator precedence and does a syntax tree rotation)bquote()is handled byBquoteHandler, the first customEffectHandler.