Repository navigation
Canonical path verification for symlink safety in ServeFiles #89
SeanTAllen
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
FilePath.from()checks the normalized path, not the resolved path. If a symlink inside the served directory points outside it,FilePath.from()succeeds and the file is served.A canonical path verification step after
FilePath.from()would catch this by resolving symlinks and re-checking that the final path is still under the root.All reactions