Update to work with pony 0.74.0 (#132)

Pony 0.74.0 merged the pony_check package into pony_test.
Property1 becomes Property, and property tests register
through test.property() instead of Property1UnitTest wrappers.

Author: SeanTAllen

.release-notes/update-to-pony-0.74.0.md

@@ -0,0 +1,3 @@
+## Update to work with pony 0.74.0
+
+Pony 0.74.0 merged the `pony_check` package into `pony_test`. This release updates hobby to use the merged API. The minimum required ponyc version is now 0.74.0.

README.md

@@ -8,7 +8,7 @@ hobby is beta quality software that will change frequently. Expect breaking chan
 
 ## Installation
 
-* Requires ponyc 0.73.0 or later.
+* Requires ponyc 0.74.0 or later.
 * Install [corral](https://github.com/ponylang/corral)
 * `corral add github.com/ponylang/hobby.git --version 0.17.0`
 * `corral fetch` to fetch your dependencies

corral.json

@@ -13,7 +13,7 @@
   "deps": [
     {
       "locator": "github.com/ponylang/stallion.git",
-      "version": "0.14.0"
+      "version": "0.15.0"
     }
   ]
 }

hobby/_test_content_type.pony

@@ -1,13 +1,12 @@
 use "pony_test"
-use "pony_check"
 
 primitive \nodoc\ _TestContentTypeList
   fun tests(test: PonyTest) =>
-    test(Property1UnitTest[String](_PropertyKnownExtensionMapsToMIME))
-    test(Property1UnitTest[String](_PropertyUnknownExtensionMapsToOctetStream))
+    test.property(_PropertyKnownExtensionMapsToMIME)
+    test.property(_PropertyUnknownExtensionMapsToOctetStream)
     test(_TestContentTypeCaseInsensitive)
-    test(Property1UnitTest[(String, String)](_PropertyOverrideReplacesDefault))
-    test(Property1UnitTest[(String, String)](_PropertyOverrideAddsNew))
+    test.property(_PropertyOverrideReplacesDefault)
+    test.property(_PropertyOverrideAddsNew)
     test(_TestOverridePreservesDefaults)
     test(_TestOverrideCaseInsensitive)
 
@@ -41,7 +40,7 @@ primitive \nodoc\ _GenMIMEType
       .map[String]({(s: String): String => "test/" + s })
 
 // --- Property tests ---
-class \nodoc\ iso _PropertyKnownExtensionMapsToMIME is Property1[String]
+class \nodoc\ iso _PropertyKnownExtensionMapsToMIME is Property[String]
   """
   Every known extension maps to a non-empty, non-default MIME type.
   """
@@ -56,7 +55,7 @@ class \nodoc\ iso _PropertyKnownExtensionMapsToMIME is Property1[String]
     h.assert_ne[String]("application/octet-stream", mime)
 
 class \nodoc\ iso _PropertyUnknownExtensionMapsToOctetStream is
-  Property1[String]
+  Property[String]
   """
   Unknown extensions map to application/octet-stream.
   """
@@ -70,7 +69,7 @@ class \nodoc\ iso _PropertyUnknownExtensionMapsToOctetStream is
     h.assert_eq[String]("application/octet-stream", ct(ext))
 
 class \nodoc\ iso _PropertyOverrideReplacesDefault is
-  Property1[(String, String)]
+  Property[(String, String)]
   """
   Overriding a known extension replaces the default MIME type.
   """
@@ -86,7 +85,7 @@ class \nodoc\ iso _PropertyOverrideReplacesDefault is
     h.assert_eq[String](mime, ct(ext))
 
 class \nodoc\ iso _PropertyOverrideAddsNew is
-  Property1[(String, String)]
+  Property[(String, String)]
   """
   Adding an unknown extension via add makes it resolvable.
   """

hobby/_test_etag.pony

@@ -1,5 +1,4 @@
 use "pony_test"
-use "pony_check"
 
 primitive \nodoc\ _TestETagList
   fun tests(test: PonyTest) =>
@@ -12,8 +11,8 @@ primitive \nodoc\ _TestETagList
     test(_TestETagCommaSeparatedNoMatch)
     test(_TestETagStrongMatchesWeak)
     test(_TestETagCaseInsensitivePrefix)
-    test(Property1UnitTest[(U64, USize, I64)](_PropertyETagSelfMatch))
-    test(Property1UnitTest[(U64, USize, I64)](_PropertyETagWildcardMatch))
+    test.property(_PropertyETagSelfMatch)
+    test.property(_PropertyETagWildcardMatch)
 
 // --- Example-based tests ---
 class \nodoc\ iso _TestETagFormat is UnitTest
@@ -105,7 +104,7 @@ class \nodoc\ iso _TestETagCaseInsensitivePrefix is UnitTest
     h.assert_true(_ETag.matches("w/\"1-20-12345\"", etag))
 
 // --- Property tests ---
-class \nodoc\ iso _PropertyETagSelfMatch is Property1[(U64, USize, I64)]
+class \nodoc\ iso _PropertyETagSelfMatch is Property[(U64, USize, I64)]
   """
   An ETag always matches itself (all three components varied).
   """
@@ -120,7 +119,7 @@ class \nodoc\ iso _PropertyETagSelfMatch is Property1[(U64, USize, I64)]
     let etag = _ETag(inode, size, mtime)
     h.assert_true(_ETag.matches(etag, etag))
 
-class \nodoc\ iso _PropertyETagWildcardMatch is Property1[(U64, USize, I64)]
+class \nodoc\ iso _PropertyETagWildcardMatch is Property[(U64, USize, I64)]
   """
   `*` matches any generated ETag (all three components varied).
   """

hobby/_test_http_date.pony

@@ -1,15 +1,14 @@
 use "pony_test"
-use "pony_check"
 
 primitive \nodoc\ _TestHTTPDateList
   fun tests(test: PonyTest) =>
     test(_TestHTTPDateEpochZero)
     test(_TestHTTPDateSunday)
     test(_TestHTTPDateKnownDate)
-    test(Property1UnitTest[I64](_PropertyHTTPDateLength))
-    test(Property1UnitTest[I64](_PropertyHTTPDateEndsWithGMT))
-    test(Property1UnitTest[I64](_PropertyHTTPDateStartsWithDayName))
-    test(Property1UnitTest[I64](_PropertyHTTPDateDayPadded))
+    test.property(_PropertyHTTPDateLength)
+    test.property(_PropertyHTTPDateEndsWithGMT)
+    test.property(_PropertyHTTPDateStartsWithDayName)
+    test.property(_PropertyHTTPDateDayPadded)
 
 // --- Generators ---
 primitive \nodoc\ _GenEpochSeconds
@@ -53,7 +52,7 @@ class \nodoc\ iso _TestHTTPDateKnownDate is UnitTest
       "Mon, 15 Jul 2024 14:30:00 GMT", _HTTPDate(1_721_053_800))
 
 // --- Property tests ---
-class \nodoc\ iso _PropertyHTTPDateLength is Property1[I64]
+class \nodoc\ iso _PropertyHTTPDateLength is Property[I64]
   """
   IMF-fixdate is always 29 characters.
   """
@@ -64,7 +63,7 @@ class \nodoc\ iso _PropertyHTTPDateLength is Property1[I64]
   fun property(seconds: I64, h: PropertyHelper) =>
     h.assert_eq[USize](29, _HTTPDate(seconds).size())
 
-class \nodoc\ iso _PropertyHTTPDateEndsWithGMT is Property1[I64]
+class \nodoc\ iso _PropertyHTTPDateEndsWithGMT is Property[I64]
   """
   Output always ends with ' GMT'.
   """
@@ -78,7 +77,7 @@ class \nodoc\ iso _PropertyHTTPDateEndsWithGMT is Property1[I64]
       result.contains(" GMT"),
       "Expected ' GMT' suffix in: " + result)
 
-class \nodoc\ iso _PropertyHTTPDateStartsWithDayName is Property1[I64]
+class \nodoc\ iso _PropertyHTTPDateStartsWithDayName is Property[I64]
   """
   Output always starts with a valid 3-letter day name followed by ', '.
   """
@@ -103,7 +102,7 @@ class \nodoc\ iso _PropertyHTTPDateStartsWithDayName is Property1[I64]
       found,
       "Expected valid day prefix in: " + result)
 
-class \nodoc\ iso _PropertyHTTPDateDayPadded is Property1[I64]
+class \nodoc\ iso _PropertyHTTPDateDayPadded is Property[I64]
   """
   Day-of-month is always 2 digits (zero-padded).
   """

hobby/_test_route_group.pony

@@ -1,19 +1,13 @@
 use "pony_test"
-use "pony_check"
 use "collections"
 use stallion = "stallion"
 
 primitive \nodoc\ _TestRouteGroupList
   fun tests(test: PonyTest) =>
     // Property tests
-    test(Property1UnitTest[
-      (String, String)](_PropertyGroupPrefixMatches))
-    test(Property1UnitTest[
-      (String, String, String)](
-      _PropertyNestedGroupPrefixOrder))
-    test(Property1UnitTest[
-      (String, String)](
-      _PropertyGroupFlattenEquivalence))
+    test.property(_PropertyGroupPrefixMatches)
+    test.property(_PropertyNestedGroupPrefixOrder)
+    test.property(_PropertyGroupFlattenEquivalence)
     // Example tests
     test(_TestJoinPath)
     test(_TestEmptyGroup)
@@ -32,7 +26,7 @@ primitive \nodoc\ _GenSegment
 
 // --- Property tests ---
 class \nodoc\ iso _PropertyGroupPrefixMatches is
-  Property1[(String, String)]
+  Property[(String, String)]
   """
   A route registered via a group matches at the joined path.
   """
@@ -58,7 +52,7 @@ class \nodoc\ iso _PropertyGroupPrefixMatches is
     end
 
 class \nodoc\ iso _PropertyNestedGroupPrefixOrder is
-  Property1[(String, String, String)]
+  Property[(String, String, String)]
   """
   Nested group paths join as outer + inner + route.
   """
@@ -87,7 +81,7 @@ class \nodoc\ iso _PropertyNestedGroupPrefixOrder is
     end
 
 class \nodoc\ iso _PropertyGroupFlattenEquivalence is
-  Property1[(String, String)]
+  Property[(String, String)]
   """
   Flattened group route matches the same as a manually built route.
   """

hobby/_test_router.pony

@@ -1,26 +1,21 @@
 use "pony_test"
-use "pony_check"
 use "collections"
 use stallion = "stallion"
 
 primitive \nodoc\ _TestRouterList
   fun tests(test: PonyTest) =>
-    test(Property1UnitTest[String](_PropertyStaticRouteMatches))
-    test(Property1UnitTest[String](_PropertyUnregisteredReturnsMiss))
-    test(Property1UnitTest[
-      (String, String)](_PropertyParamExtraction))
-    test(Property1UnitTest[
-      (String, String, String)](_PropertyMultipleParams))
-    test(Property1UnitTest[stallion.Method](_PropertyMethodIsolation))
-    test(Property1UnitTest[String](_PropertyWildcardCapture))
+    test.property(_PropertyStaticRouteMatches)
+    test.property(_PropertyUnregisteredReturnsMiss)
+    test.property(_PropertyParamExtraction)
+    test.property(_PropertyMultipleParams)
+    test.property(_PropertyMethodIsolation)
+    test.property(_PropertyWildcardCapture)
     test(_TestStaticPriorityOverParam)
     test(_TestRootPath)
     test(_TestOverlappingPrefixes)
     test(_TestWildcardSingleSegment)
     test(_TestTrailingSlashNormalization)
-    test(Property1UnitTest[
-      (Array[USize] val, Array[USize] val)](
-      _PropertyInsertionOrderInvariance))
+    test.property(_PropertyInsertionOrderInvariance)
     test(_TestHeadFallbackInRouter)
     test(_TestInterceptorAccumulation)
     test(_TestMissCarriesInterceptors)
@@ -51,7 +46,7 @@ primitive \nodoc\ _TestRouterList
     test(_TestDoubleSlashNormalization)
     test(_TestWildcardDoubleSlashNormalization)
     test(_TestSplitSegmentsEdgeCases)
-    test(Property1UnitTest[String](_PropertySplitJoinRoundTrip))
+    test.property(_PropertySplitJoinRoundTrip)
     test(_TestJoinRemainingSegments)
     test(_TestRoutesBeforeInterceptors)
     test(_TestMethodNotAllowedCarriesInterceptors)
@@ -113,7 +108,7 @@ primitive \nodoc\ _NoOpFactory
     RequestHandler(consume ctx).respond(stallion.StatusOK, "ok")
 
 // --- Property tests ---
-class \nodoc\ iso _PropertyStaticRouteMatches is Property1[String]
+class \nodoc\ iso _PropertyStaticRouteMatches is Property[String]
   """
   A registered static route always matches.
   """
@@ -132,7 +127,7 @@ class \nodoc\ iso _PropertyStaticRouteMatches is Property1[String]
       h.fail("expected match for " + path)
     end
 
-class \nodoc\ iso _PropertyUnregisteredReturnsMiss is Property1[String]
+class \nodoc\ iso _PropertyUnregisteredReturnsMiss is Property[String]
   """
   An unregistered path returns _RouteMiss.
   """
@@ -151,7 +146,7 @@ class \nodoc\ iso _PropertyUnregisteredReturnsMiss is Property1[String]
     end
 
 class \nodoc\ iso _PropertyParamExtraction is
-  Property1[(String, String)]
+  Property[(String, String)]
   """
   `:name` segments are captured correctly.
   """
@@ -182,7 +177,7 @@ class \nodoc\ iso _PropertyParamExtraction is
     end
 
 class \nodoc\ iso _PropertyMultipleParams is
-  Property1[(String, String, String)]
+  Property[(String, String, String)]
   """
   Multiple `:name` segments are all extracted.
   """
@@ -221,7 +216,7 @@ class \nodoc\ iso _PropertyMultipleParams is
     end
 
 class \nodoc\ iso _PropertyMethodIsolation is
-  Property1[stallion.Method]
+  Property[stallion.Method]
   """
   A route registered for one method does not match another.
   """
@@ -259,7 +254,7 @@ class \nodoc\ iso _PropertyMethodIsolation is
       h.fail("should be 405, not 404")
     end
 
-class \nodoc\ iso _PropertyWildcardCapture is Property1[String]
+class \nodoc\ iso _PropertyWildcardCapture is Property[String]
   """
   `*name` captures the remainder of the path.
   """
@@ -830,7 +825,7 @@ class \nodoc\ iso _Test405MergeDeduplicatesOverlappingMethods
 
 // --- Property test: insertion order invariance ---
 class \nodoc\ iso _PropertyInsertionOrderInvariance is
-  Property1[(Array[USize] val, Array[USize] val)]
+  Property[(Array[USize] val, Array[USize] val)]
   """
   Route lookup results are independent of insertion order.
 
@@ -1862,7 +1857,7 @@ class \nodoc\ iso _TestSplitSegmentsEdgeCases is UnitTest
       h.fail("param/wildcard segment access failed")
     end
 
-class \nodoc\ iso _PropertySplitJoinRoundTrip is Property1[String]
+class \nodoc\ iso _PropertySplitJoinRoundTrip is Property[String]
   """
   Splitting a static path into segments and joining them all back produces
   the original path without the leading slash.