Support inverse boolean data-element bindings (#547)

* test: cover inverse boolean element presence for #466

* fix: support inverse boolean data-element bindings

Author: g105b

src/HTMLAttributeBinder.php

@@ -120,9 +120,17 @@ private function markBoundElement(
 		?string $key,
 		mixed $value,
 	):void {
-		if($attribute->name === "data-element"
-		&& $attribute->value === $key
-		&& $value) {
+		if($attribute->name !== "data-element") {
+			return;
+		}
+
+		$bindKey = $attribute->value;
+		if(str_starts_with($bindKey, "!")) {
+			$bindKey = substr($bindKey, 1);
+			$value = !$value;
+		}
+
+		if($bindKey === $key && $value) {
 			$element->setAttribute("data-bound", "");
 		}
 	}

test/phpunit/DocumentBinderTest.php

@@ -36,6 +36,7 @@
 use GT\DomTemplate\Test\TestHelper\Model\IteratorAggregate\Student\Module;
 use GT\DomTemplate\Test\TestHelper\Model\IteratorAggregate\Student\Name;
 use GT\DomTemplate\Test\TestHelper\Model\IteratorAggregate\Student\Student;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use stdClass;
 use IteratorAggregate;
@@ -1526,6 +1527,78 @@ public function test_bindElementWithBindValue():void {
 		self::assertSame("There has been an error!", $errorDiv->textContent);
 	}
 
+	#[DataProvider("inverseElementPresenceProvider")]
+	public function testBindElement_inverseBoolean(
+		string $expression,
+		mixed $value,
+		bool $bind,
+		bool $retained,
+	):void {
+		$document = new HTMLDocument('<div id="target" data-element="' . $expression . '">Static content</div>');
+		$sut = new DocumentBinder($document);
+		$sut->setDependencies(...$this->documentBinderDependencies($document));
+		if($bind) {
+			$sut->bindKeyValue("isAdmin", $value);
+		}
+		$sut->cleanupDocument();
+
+		$target = $document->getElementById("target");
+		if(!$retained) {
+			self::assertNull($target);
+			return;
+		}
+
+		self::assertNotNull($target);
+		self::assertSame("Static content", $target->textContent);
+		self::assertFalse($target->hasAttribute("data-element"));
+		self::assertFalse($target->hasAttribute("data-bound"));
+	}
+
+	public static function inverseElementPresenceProvider():array {
+		$cases = [];
+		foreach(["isAdmin", "!isAdmin"] as $expression) {
+			$inverse = str_starts_with($expression, "!");
+			foreach([true, false, 1, 0, "admin", "", "0"] as $index => $value) {
+				$cases["$expression value $index"] = [$expression, $value, true, $inverse ? !$value : (bool)$value];
+			}
+			$cases["$expression unbound"] = [$expression, false, false, false];
+			$cases["$expression null"] = [$expression, null, true, false];
+		}
+		$cases["unrelated inverse key"] = ["!otherKey", false, true, false];
+		return $cases;
+	}
+
+	#[DataProvider("inverseAttributeElementProvider")]
+	public function testBindElement_inverseAttributeSurvivesCleanup(
+		string $modifier,
+		bool $value,
+	):void {
+		$isToken = str_contains($modifier, ":");
+		$property = $isToken ? "class" : "disabled";
+		$expression = $modifier . "isEnabled" . ($isToken ? " hidden" : "");
+		$document = new HTMLDocument('<button id="target" data-element data-bind:' . $property . '="' . $expression . '">Action</button>');
+		$sut = new DocumentBinder($document);
+		$sut->setDependencies(...$this->documentBinderDependencies($document));
+		$sut->bindKeyValue("isEnabled", $value);
+		$sut->cleanupDocument();
+
+		$target = $document->getElementById("target");
+		self::assertNotNull($target);
+		self::assertSame(!$value, $isToken ? $target->classList->contains("hidden") : $target->hasAttribute("disabled"));
+		self::assertFalse($target->hasAttribute("data-element"));
+		self::assertFalse($target->hasAttribute("data-bound"));
+	}
+
+	public static function inverseAttributeElementProvider():array {
+		$cases = [];
+		foreach(["?!", "!?", ":!", "!:"] as $modifier) {
+			foreach([true, false] as $value) {
+				$cases[$modifier . ($value ? " true" : " false")] = [$modifier, $value];
+			}
+		}
+		return $cases;
+	}
+
 	public function test_bindElementRemovesMultiple():void {
 		$document = new HTMLDocument(HTMLPageContent::HTML_ADMIN_PANEL);
 		$sut = new DocumentBinder($document);