Skip to content

[release-ocm-2.15] ACM-32285: CVE-2026-42306 Bump assisted-service dep to pick up docker v28.5.2 - #1563

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift:release-ocm-2.15from
shay23bra:as-bump-docker-release-ocm-2.15
Aug 9, 2026
Merged

[release-ocm-2.15] ACM-32285: CVE-2026-42306 Bump assisted-service dep to pick up docker v28.5.2#1563
openshift-merge-bot[bot] merged 4 commits into
openshift:release-ocm-2.15from
shay23bra:as-bump-docker-release-ocm-2.15

Conversation

@shay23bra

@shay23bra shay23bra commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Bump assisted-service dependency to latest commit which includes docker/docker v28.5.2, fixing CVE-2026-42306.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 26, 2026

Copy link
Copy Markdown

@shay23bra: This pull request references ACM-32285 which is a valid jira issue.

Details

In response to this:

Bump assisted-service dependency to latest commit which includes docker/docker v28.5.2, fixing CVE-2026-42306.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e40e27b4-2ebd-4d6b-b935-ebfa83c6e205

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 26, 2026
@openshift-ci
openshift-ci Bot requested review from rccrdpccl and romfreiman July 26, 2026 12:22
@codecov

codecov Bot commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.68%. Comparing base (61f7247) to head (3419969).
⚠️ Report is 9 commits behind head on release-ocm-2.15.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.15    #1563   +/-   ##
=================================================
  Coverage             55.68%   55.68%           
=================================================
  Files                    88       88           
  Lines                  4443     4443           
=================================================
  Hits                   2474     2474           
  Misses                 1789     1789           
  Partials                180      180
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shay23bra
Use -mod=mod for unit tests to match Dockerfile build behavior
6d6fb28 
The Dockerfile already builds with GOFLAGS=-mod=mod. Align unit tests
to use the same mode, avoiding issues with vendored packages that
have subdirectories matching .gitignore patterns (e.g. build/).
@shay23bra

shay23bra commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@shay23bra
Use -mod=mod for builds to match assisted-installer behavior
23aa219 
The vendored docker/docker v28.5.2 includes an api/types/build sub-package
that conflicts with .gitignore build rule. Use -mod=mod for all Go build
and test commands to resolve dependencies from the module cache instead
of the incomplete vendor directory.
@shay23bra
Fix .gitignore to use /build instead of build
3419969 
Align with assisted-service .gitignore pattern. The bare 'build' rule
incorrectly excludes vendored packages containing build/ subdirectories
(e.g. docker/docker/api/types/build). Use /build to only ignore the
project root build directory.

Revert -mod=mod workaround as it is no longer needed.
@gamli75

gamli75 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-ai-operator-ztp
/test subsystem-test

@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2026
@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 1af0686 into openshift:release-ocm-2.15 Aug 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rccrdpccl rccrdpccl Awaiting requested review from rccrdpccl
@romfreiman romfreiman Awaiting requested review from romfreiman

Assignees

@gamli75 gamli75

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shay23bra @openshift-ci-robot @gamli75