Skip to content

CI does not typecheck test files #294

Description

@arbrandes

Description

Nothing in CI typechecks test files, so type errors in *.test.ts and *.test.tsx can land on main unnoticed.

tsconfig.build.json excludes **/*.test.{js,jsx,ts,tsx} from the build, and npm run test transpiles through Babel, which does no typechecking. The error fixed in #288 was only caught locally by npm run dev, because dev:shell runs fork-ts-checker-webpack-plugin against the root tsconfig.json, whose include does cover test files.

Adding a tsc --noEmit -p tsconfig.json step to .github/workflows/ci.yml would close the gap.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions